Re: Review Request 55890: GEODE-2354: set global session timeout to MAX_VALUE

2017-01-25 Thread Kirk Lund
> On Jan. 25, 2017, 9:59 p.m., Swapnil Bawaskar wrote: > > Form this page (https://shiro.apache.org/session-management.html): > > "By default, Shiro’s SessionManager implementations default to a 30 minute > > session timeout. That is, if any Session created remains idle (unused, > > where its l

Re: Review Request 55890: GEODE-2354: set global session timeout to MAX_VALUE

2017-01-25 Thread Swapnil Bawaskar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55890/#review163027 --- Form this page (https://shiro.apache.org/session-management.html):

Re: Review Request 55890: GEODE-2354: set global session timeout to MAX_VALUE

2017-01-25 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55890/#review163000 --- Ship it! Ship It! - Jared Stewart On Jan. 25, 2017, 7:01 p.m

Re: Review Request 55890: GEODE-2354: set global session timeout to MAX_VALUE

2017-01-25 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55890/ --- (Updated Jan. 25, 2017, 7:01 p.m.) Review request for geode, Jinmei Liao, Jared

Re: Review Request 55890: GEODE-2354: set global session timeout to MAX_VALUE

2017-01-25 Thread Kirk Lund
> On Jan. 24, 2017, 10:22 p.m., Jared Stewart wrote: > > Do you think we ought to add a test to make sure the session timeout > > actually got set? E.g. if `shiroManager.getSessionManager()` is not > > returning us a `DefaultSessionManager` then we won't have set a timeout I like the idea of

Re: Review Request 55890: GEODE-2354: set global session timeout to MAX_VALUE

2017-01-25 Thread Kevin Duling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55890/#review162976 --- Ship it! Ship It! - Kevin Duling On Jan. 24, 2017, 12:55 p.m

Re: Review Request 55890: GEODE-2354: set global session timeout to MAX_VALUE

2017-01-24 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55890/#review162861 --- Ship it! Do you think we ought to add a test to make sure the s