Re: Rat check reporting error in travis-ci for geode-native

2019-08-22 Thread Alberto Gomez
I created the following PR to fix the Rat error. https://github.com/apache/geode-native/pull/512 Could someone review it and merge it if correct? Thanks, -Alberto G. On 21/8/19 23:59, Dan Smith wrote: > Hi Helena, > > I think the problem is that rat is currently broken on geode-native > develo

Re: Rat check reporting error in travis-ci for geode-native

2019-08-21 Thread Dan Smith
Hi Helena, I think the problem is that rat is currently broken on geode-native develop. -Dan On Wed, Aug 21, 2019 at 2:55 PM Helena Bales wrote: > Hi Alberto, > > If you have added a file as part of your PR, please add the header as a > commit to your working branch and add that as part of the

Re: Rat check reporting error in travis-ci for geode-native

2019-08-21 Thread Helena Bales
Hi Alberto, If you have added a file as part of your PR, please add the header as a commit to your working branch and add that as part of the same PR. Your branch should be able to pass a build, spotlessCheck, and unit tests as a prerequisite for making a pull request. Please follow up here if yo