Re: Proposal to include GEODE-7088 and GEODE-7089 in 1.10.0

There appears to be consensus that these are critical fixes. The following commits have been brought into release/1.10.0 as the critical fix for GEODE-7088 : git cherry-pick -x 174af1d23fb7e0

Re: Proposal to include GEODE-7088 and GEODE-7089 in 1.10.0

The cherry-pick for GEODE-7088 is clean so I didn't open a PR for that one. The cherry-pick for GEODE-7089 required manual merging due to several unrelated stats changes added to develop recently. The PR to merge that one into release/1.10.0 is here: https://github.com/apache/geode/pull/3976 The

Re: Proposal to include GEODE-7088 and GEODE-7089 in 1.10.0

Thank you Ryan, +1 for inclusion On 8/26/19 3:33 PM, Ryan McMahon wrote: Udo, Here are inline answers to your questions: *Is this an existing issue?* Short answer - yes, but it has never been in a release version of Geode. The leak was introduced as part of some changes to address handling m

Re: Proposal to include GEODE-7088 and GEODE-7089 in 1.10.0

+1 This will be a good inclusion in Apache Geode 1.10.0 release. Regards Naba On Mon, Aug 26, 2019 at 3:36 PM Jacob Barrett wrote: > +1 > > Thanks for the details! > > > On Aug 26, 2019, at 3:33 PM, Ryan McMahon wrote: > > > > Udo, > > > > Here are inline answers to your questions: > > > > *I

Re: Proposal to include GEODE-7088 and GEODE-7089 in 1.10.0

+1 Thanks for the details! > On Aug 26, 2019, at 3:33 PM, Ryan McMahon wrote: > > Udo, > > Here are inline answers to your questions: > > *Is this an existing issue?* > > Short answer - yes, but it has never been in a release version of Geode. > The leak was introduced as part of some change

Re: Proposal to include GEODE-7088 and GEODE-7089 in 1.10.0

Udo, Here are inline answers to your questions: *Is this an existing issue?* Short answer - yes, but it has never been in a release version of Geode. The leak was introduced as part of some changes to address handling multiple concurrent registration requests for a given client on a single serve

Re: Proposal to include GEODE-7088 and GEODE-7089 in 1.10.0

Hi Ryan, thank you for bringing your concern. Geode's release process dictates a time-based schedule to cut release branches. The release/1.10.0 branch was already cut ov

Re: Proposal to include GEODE-7088 and GEODE-7089 in 1.10.0

In order to better understand this request: Is this an existing issue? Why is it more critical to squeeze it into an existing (almost release) version of Apache Geode? What guarantees do we have that this fix makes the application more stable compared to adding another hidden issue, which we