Re: New release branch for Apache Geode 1.10.0

2019-08-02 Thread Owen Nichols
There appears to be consensus that this is a critical fix. The following commits have been brought into support/1.10.0 as the critical fix for GEODE-7001 : git cherry-pick -x 81f8f9c1ca1ec9a5

Re: New release branch for Apache Geode 1.10.0

2019-08-02 Thread Nabarun Nag
Thank you Aaron and Kirk for getting the fix in. Regards Naba On Fri, Aug 2, 2019 at 5:25 PM Aaron Lindsey wrote: > +1 to including this PR in the 1.10.0 release. > > Just to elaborate on the issue: If the stats sampler calls > LocalRegion.getLocalSize before that region is initialized, it wi

Re: New release branch for Apache Geode 1.10.0

2019-08-02 Thread Aaron Lindsey
+1 to including this PR in the 1.10.0 release. Just to elaborate on the issue: If the stats sampler calls LocalRegion.getLocalSize before that region is initialized, it will throw a NullPointerException. This can happen because we have escaping references to “this” in the LocalRegion constructo

Re: New release branch for Apache Geode 1.10.0

2019-08-02 Thread Michael Oleske
Naba's concern was this PR: https://github.com/apache/geode/pull/3880 which has been merged to develop -michael On Fri, Aug 2, 2019 at 4:33 PM Owen Nichols wrote: > Hi Naba, thank you for bringing your concern. > > Our current process < > https://lists.apache.org/thread.html/d36a63c3794d13506ec

Re: New release branch for Apache Geode 1.10.0

2019-08-02 Thread Owen Nichols
Hi Naba, thank you for bringing your concern. Our current process dictates a time-based schedule to cut release branches. Once cut, the “critical fixes” rule allows critic

Re: New release branch for Apache Geode 1.10.0

2019-08-02 Thread Nabarun Nag
Hi, We believe that the current release branch has an issue of getting a NullPointerException when we try calling LocalRegion.getLocalSize when the region is in the process of being initialized. The fix for this issue is very critical and we should re-create the branch when the fix is placed in de