Ah! I forgot about that (trying to do too many things at once). I'll file a
ticket to fix it up. Thanks!
On Wed, Jan 16, 2019 at 3:47 PM Bruce Schuchardt
wrote:
> Hmm, okay but I was looking at this code in MBeanJMXAdapter:
>
> public static String getMemberNameOrId(DistributedMember member) {
>
Hmm, okay but I was looking at this code in MBeanJMXAdapter:
public static String getMemberNameOrId(DistributedMember member) {
if (member.getName() !=null && !member.getName().equals("")) {
return makeCompliantName(member.getName());
}
return makeCompliantName(member.getId());
}
So if
It's not using toString(). It's just using DistributedMember.getName().
This is implemented by InternalDistributedMember.getName() which delegates
to NetMember.getName(). Are you saying we should add a new method to
DistributedMember instead of using getName()?
The mbeans are categorized a type of
Yeah, let's fix this, but let's not require the toString() of an object
to never change. Let's add another method that returns a Bean
identifier and is documented to never change.
On 1/15/19 9:45 AM, Kirk Lund wrote:
Sorry about the confusion. I meant that the change of membership port
result
Sorry about the confusion. I meant that the change of membership port
results in DistributedMember returning a different string from its
getName() method.
We discovered this because the JMX layer has some error handling that
results in suppressing this failure, so the failure was being hidden. We
Actually the formatting code would go in InternalDistributedMember. The
JMX code already has a special method for handling that class. I was
thrown off by the reference to a non-existant getName() method in
LonerDistributionManager.
On 1/15/19 7:34 AM, Bruce Schuchardt wrote:
I think we coul
I think we could solve this by either moving the ID formatting code to
the DistributionManager implementations & having
LonerDistributionManager omit the port number or modify the
client/server handshake to not install a port number when connecting to
a remote GatewayReceiver. I guess the latt
