Re: Issues due to Special exceptions in RVV

2017-05-23 Thread Darrel Schneider
Yes, please file a jira and share your fix. We are wondering if in delta GII it would just cause some extra entries to be sent. In that case it will just impact performance but not data consistency. What kind of issues are you seeing? On Tue, May 23, 2017 at 11:54 AM, Suranjan Kumar wrote: > H

Re: Issues due to Special exceptions in RVV

2017-05-23 Thread Anilkumar Gingade
Suranjan, In your run, are you seeing GII failing on one server and then continuing from another server? Say there are 3 nodes in cluster. node1 and node2 with region r1 (exists) - r1 is created on node3. - node3 starts gii from node1 (gets disconnected in between). - node3 starts gii from no

Re: Issues due to Special exceptions in RVV

2017-05-23 Thread Suranjan Kumar
Hi Darrel, Actually, I reproduced the issue in unit test that was seen in one of the runs and initializeVersionHolder doesn't fix the issue. The initializeFrom is used to initialize a member's RVV from a GII provider. It turns out if a member has already recorded higher version then while i

Re: Issues due to Special exceptions in RVV

2017-05-23 Thread Darrel Schneider
I see that this test directly calls initializeFrom but the product never does this. The product always calls it through this method: org.apache.geode.internal.cache.versions.RegionVersionVector.initializeVersionHolder(T, RegionVersionHolder) I can see that initializeVersionHolder checks a memberT

Re: Issues due to Special exceptions in RVV

2017-05-23 Thread Darrel Schneider
I made these modifications and the following compiles, runs, and fails on geode. I added the following to RegionVersionVectorJUnitTest: @Test public void testInitialized() { RegionVersionHolder vh1 = new RegionVersionHolder<>("vh1"); vh1.recordVersion(56); vh1.recordVersion(57);

Re: Issues due to Special exceptions in RVV

2017-05-23 Thread Kirk Lund
Are you sure you're using Geode? The signature of RegionVersionHolder#recordVersion in Geode is: RegionVersionHolder#recordVersion(long) I recommend checking out develop branch of Geode, write a test to confirm your bug and then submit that test with a Jira ticket. On Tue, May 23, 2017 at 7:10 A