Re: Deleting old references to ticket numbers and avoiding new ones

2021-03-30 Thread Dave Barnes
I STRONGLY AGREE with avoiding Jira ticket numbers in code comments. In an open-source system, code comments function as user-visible documentation (whether or not they're flagged for inclusion in the Javadocs), so rather than resorting to a ticket number in place of an explanation, provide the exp

Re: Deleting old references to ticket numbers and avoiding new ones

2021-03-30 Thread Donal Evans
+1 In theory, every commit is now associated with a GEODE jira ticket, so leaving a comment in the code when putting in a fix saying that it's for that ticket is redundant. Good commit names and messages would provide the broader context for changes, and regular comments that don't refer to a t

Re: Deleting old references to ticket numbers and avoiding new ones

2021-03-30 Thread Jacob Barrett
+1 I am pretty sure we had this discussion a long time ago and agreed to it. I can’t view the archives though since it appears markmail doesn’t like newer versions of Chrome or Safari. -Jake > On Mar 30, 2021, at 2:24 PM, Hale Bales wrote: > > Hi all, > > I have noticed in the past that the