Re: CODEWATCHERS file effects

2021-03-24 Thread Alberto Gomez
hols Sent: Wednesday, March 24, 2021 11:39 AM To: dev@geode.apache.org Subject: Re: CODEWATCHERS file effects Thanks Alberto for the detailed list. I think I was able to find explanations for all, see below. > https://github.com/apache/geode/pull/6177 # geode-core/src/main/java/org/apach

Re: CODEWATCHERS file effects

2021-03-24 Thread Owen Nichols
arch 24, 2021 2:30 AM To: dev@geode.apache.org Subject: Re: CODEWATCHERS file effects Hi Alberto, is there a specific PR you feel you were added to in error? I spot-checked #6179 and there was one test change in geode-wan so that one seems correct. I am looking for a soluti

Re: CODEWATCHERS file effects

2021-03-24 Thread Alberto Gomez
/geode/pull/6116 Best regards, Alberto From: Owen Nichols Sent: Wednesday, March 24, 2021 2:30 AM To: dev@geode.apache.org Subject: Re: CODEWATCHERS file effects Hi Alberto, is there a specific PR you feel you were added to in error? I spot-checked #6179 and

Re: CODEWATCHERS file effects

2021-03-23 Thread Owen Nichols
Hi Alberto, is there a specific PR you feel you were added to in error? I spot-checked #6179 and there was one test change in geode-wan so that one seems correct. I am looking for a solution to avoid adding watchers to draft PRs until they are taken out of draft mode, but it's non-trivial so