Re: [VOTE] Requiring final keyword on every parameter and local variable

It's past the announced deadline so I've counted the results of our vote to require 'final' keyword on all local variables and method/constructor parameters. I am interpreting this vote as a procedural issue [1], and I counted votes by PMC members as "binding votes" and votes by all other particip

Re: [VOTE] Requiring final keyword on every parameter and local variable

Voting and discussion are closed for now. I'll count up the votes and post a summary soon. -Kirk On Thu, Apr 22, 2021 at 7:54 AM Bruce Schuchardt wrote: > Kirk speaks my mind. -1 on this requirement > > On 4/21/21, 11:29 AM, "Kirk Lund" wrote: > > -1 as I've already explained in my DISCU

Re: [VOTE] Requiring final keyword on every parameter and local variable

Kirk speaks my mind. -1 on this requirement On 4/21/21, 11:29 AM, "Kirk Lund" wrote: -1 as I've already explained in my DISCUSS thread for this topic, I don't think final gives sufficient benefit for local variables or method parameters because it only prevents reassigning object p

Re: [VOTE] Requiring final keyword on every parameter and local variable

y express intent. And, most importantly, function should match intent. -j From: John Blum Sent: Wednesday, April 21, 2021 6:02 PM To: dev@geode.apache.org Subject: Re: [VOTE] Requiring final keyword on every parameter and local variable I vote -1 for (general

Re: [VOTE] Requiring final keyword on every parameter and local variable

ch intent. -j From: Owen Nichols Sent: Wednesday, April 21, 2021 5:16 PM To: dev@geode.apache.org Subject: Re: [VOTE] Requiring final keyword on every parameter and local variable Good point. We're probably stuck on vanilla JDK8 for years more anywa

Re: [VOTE] Requiring final keyword on every parameter and local variable

t: Wednesday, April 21, 2021 12:59 PM To: dev@geode.apache.org Subject: Re: [VOTE] Requiring final keyword on every parameter and local variable I'm interested in https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fprojectlombok.org%2F&data=04%7C01%

Re: [VOTE] Requiring final keyword on every parameter and local variable

moing purposes. -j From: Kirk Lund Sent: Wednesday, April 21, 2021 12:59 PM To: dev@geode.apache.org Subject: Re: [VOTE] Requiring final keyword on every parameter and local variable I'm interested in https://nam04.safelinks.protection.outlook.com/?url=https%3A%2

Re: [VOTE] Requiring final keyword on every parameter and local variable

Both of these are (I think) disabled by default in IntelliJ. And > neither satisfies my “I’d be willing to automate enforcing it” test. > > Dale > > From: Mark Hanson > Date: Monday, April 19, 2021 at 11:08 AM > To: dev@geode.apache.org > Subject: Re: [

Re: [VOTE] Requiring final keyword on every parameter and local variable

-1 as I've already explained in my DISCUSS thread for this topic, I don't think final gives sufficient benefit for local variables or method parameters because it only prevents reassigning object pointers and primitive values. I favor individuals making a personal decision on whether or not they w

Re: [VOTE] Requiring final keyword on every parameter and local variable

:08 AM To: dev@geode.apache.org Subject: Re: [VOTE] Requiring final keyword on every parameter and local variable Hi Jake, I agree with everyone's point about final being a useful, I just don't find it useful enough to do anything manually across the code base at this p

Re: [VOTE] Requiring final keyword on every parameter and local variable

; on local variable or parameter Both of these are (I think) disabled by default in IntelliJ. And neither satisfies my “I’d be willing to automate enforcing it” test. Dale From: Mark Hanson Date: Monday, April 19, 2021 at 11:08 AM To: dev@geode.apache.org Subject: Re: [VOTE] Requiring final

Re: [VOTE] Requiring final keyword on every parameter and local variable

Does everyone feel that adding final here is the best thing to do? If not, then "Always" becomes "Strongly Encouraged where appropriate" protected void validateUDPEncryptionStats() { long encrptTime = getGemfireCache().getDistributionManager().getStats().getUDPMsgEncryptionTime(); long

Re: [VOTE] Requiring final keyword on every parameter and local variable

I'm planning to leave this VOTE and DISCUSSION open until Wednesday 2400 PM UTC. On Wed, Apr 14, 2021 at 12:55 PM Kirk Lund wrote: > Our coding standard and our Design Decisions does NOT require using final > on parameters and local variables. > > Please do NOT request that I add or keep final o

Re: [VOTE] Requiring final keyword on every parameter and local variable

Hi Jake, I agree with everyone's point about final being a useful, I just don't find it useful enough to do anything manually across the code base at this point. I believe first in foremost in no code warnings. Intellij warns about variables that can be final, so I make them final as it finds t

Re: [VOTE] Requiring final keyword on every parameter and local variable

> On Apr 15, 2021, at 7:49 PM, Udo Kohlmeyer wrote: > > @jake, you are correct, I did miss the LOCAL variable out of the subject. > :face_palm: > > Yes, adding "final" to LOCAL variables will be HUGELY beneficial in this > regard. Have we seen any performance improvement after having refact

Re: [VOTE] Requiring final keyword on every parameter and local variable

@jake, you are correct, I did miss the LOCAL variable out of the subject. :face_palm: Yes, adding "final" to LOCAL variables will be HUGELY beneficial in this regard. Have we seen any performance improvement after having refactored this method? Have you been able to measure any improvements? -

Re: [VOTE] Requiring final keyword on every parameter and local variable

Sorry Bruce, that's my lack of Apache finesse. I know you might expect me to remember it but I don't start discussions or votes often enough to remember. I'll be sure to read up on this process before starting any threads in the future. On Thu, Apr 15, 2021 at 7:32 AM Bruce Schuchardt wrote: > I

Re: [VOTE] Requiring final keyword on every parameter and local variable

I agree with Udo. Also, this shouldn't be a VOTE without discussion and I don't see a DISCUSS thread. On 4/14/21, 7:46 PM, "Udo Kohlmeyer" wrote: "+1" to ENCOURAGING developers to make "final" a requirement for method arguments. "-1" to making it a hard rule. If we want to enfor

Re: [VOTE] Requiring final keyword on every parameter and local variable

> On Apr 14, 2021, at 7:46 PM, Udo Kohlmeyer wrote: > @Jake the idea of smaller methods is great and we should ALWAYS strive for > that. But that argument is completely irrelevant in this discussion. As > making method arguments final does not naturally guide a developer to > creating smaller

Re: [VOTE] Requiring final keyword on every parameter and local variable

"+1" to ENCOURAGING developers to make "final" a requirement for method arguments. "-1" to making it a hard rule. If we want to enforce this rule on the basis of readability or performance, I fear that we might be beating the wrong horse here for the wrong reasons!! Short reasoning: If we rea

Re: [VOTE] Requiring final keyword on every parameter and local variable

2021 at 1:53 PM To: dev@geode.apache.org<mailto:dev@geode.apache.org> mailto:dev@geode.apache.org>> Subject: Re: [VOTE] Requiring final keyword on every parameter and local variable +1 I am 100% for putting final everywhere it is possible

Re: [VOTE] Requiring final keyword on every parameter and local variable

n region = regionFactory.create (“testRegion”); Region.put(int, String);` Thanks, Mark From: Bill Burcham Date: Wednesday, April 14, 2021 at 1:53 PM To: dev@geode.apache.org Subject: Re: [VOTE] Requiring final keyword on eve

Re: [VOTE] Requiring final keyword on every parameter and local variable

If a method is longer than a handful of lines and I go in to refactor it I am going to start by making every variable I find final. Then I am going to figure out how to keep them final. By doing so you naturally produce smaller functional methods that are usually independently unit testable. Sma

Re: [VOTE] Requiring final keyword on every parameter and local variable

Bill Burcham Date: Wednesday, April 14, 2021 at 1:53 PM To: dev@geode.apache.org Subject: Re: [VOTE] Requiring final keyword on every parameter and local variable +1 I am 100% for putting final everywhere it is possible to put it. Call this the "

Re: [VOTE] Requiring final keyword on every parameter and local variable

.create (“testRegion”); Region.put(int, String);` Thanks, Mark From: Bill Burcham Date: Wednesday, April 14, 2021 at 1:53 PM To: dev@geode.apache.org Subject: Re: [VOTE] Requiring final keyword on every parameter and local variable +1 I am 100% for putting final ever

Re: [VOTE] Requiring final keyword on every parameter and local variable

(RegionShortcut.PARTITION_REDUNDANT); Region region = regionFactory.create (“testRegion”); Region.put(int, String);` Thanks, Mark From: Bill Burcham Date: Wednesday, April 14, 2021 at 1:53 PM To: dev@geode.apache.org Subject: Re: [VOTE] Requiring final keyword on every parameter and local variable +1 I am 100% for

Re: [VOTE] Requiring final keyword on every parameter and local variable

+1 I am 100% for putting final everywhere it is possible to put it. Call this the "hard final" position. What I've been advocating for, intermittently, in PRs (for example, in PR #6310 ) is more of a "soft final" position which I ca