Re: [VOTE] Fix bad-merge of GEODE-7488

2019-11-22 Thread Udo Kohlmeyer
No brainer vote for me. +1 @Donal, overrides should only EVER be for "break glass emergency". Anybody who would abuse it for any other reason, should seriously be considered "enemy-of-the-state". --Udo On 11/22/19 11:55 AM, Robert Houghton wrote: I was overzealous in a merge to Geode, and g

Re: [VOTE] Fix bad-merge of GEODE-7488

2019-11-22 Thread Kirk Lund
+1 adding my vote On Fri, Nov 22, 2019 at 11:56 AM Robert Houghton wrote: > I was overzealous in a merge to Geode, and got us into a chicken-and-egg > issue for PRs and reverts. Calling a vote to override the GitHub merge > button restriction via commiter privileges, to merge the fix in > https:

Re: [VOTE] Fix bad-merge of GEODE-7488

2019-11-22 Thread Donal Evans
+1 While I'm against overriding PR checks in general, this is clearly a special case. On Fri, Nov 22, 2019 at 12:10 PM Nabarun Nag wrote: > +1 > > On Fri, Nov 22, 2019 at 12:00 PM Anthony Baker wrote: > > > Clearly the right thing to do is fix it. VOTE not needed IMO. > > > > Anthony > > > >

Re: [VOTE] Fix bad-merge of GEODE-7488

2019-11-22 Thread Nabarun Nag
+1 On Fri, Nov 22, 2019 at 12:00 PM Anthony Baker wrote: > Clearly the right thing to do is fix it. VOTE not needed IMO. > > Anthony > > > > On Nov 22, 2019, at 11:55 AM, Robert Houghton > wrote: > > > > I was overzealous in a merge to Geode, and got us into a chicken-and-egg > > issue for PRs

Re: [VOTE] Fix bad-merge of GEODE-7488

2019-11-22 Thread Dan Smith
+1 Go for it. -Dan On Fri, Nov 22, 2019 at 12:07 PM Owen Nichols wrote: > It would set a bad precedent to circumvent without due process a decision > that was agreed by the Geode community < > https://lists.apache.org/thread.html/1ba19d9aeb206148c922afdd182ba322d6f128bbb83983f2f72a108e@%3Cdev.g

Re: [VOTE] Fix bad-merge of GEODE-7488

2019-11-22 Thread Owen Nichols
It would set a bad precedent to circumvent without due process a decision that was agreed by the Geode community . > On Nov 22, 2019, at 12:00 PM, Anthony Baker wrote: > >

Re: [VOTE] Fix bad-merge of GEODE-7488

2019-11-22 Thread Anthony Baker
Clearly the right thing to do is fix it. VOTE not needed IMO. Anthony > On Nov 22, 2019, at 11:55 AM, Robert Houghton wrote: > > I was overzealous in a merge to Geode, and got us into a chicken-and-egg > issue for PRs and reverts. Calling a vote to override the GitHub merge > button restricti