Re: [VOTE] Apache Geode 1.10.0.RC1

It's been found that the issue affecting Geode Native integration tests was introduced in 1.9.0 with the following commit: https://github.com/apache/geode/commit/2d6a6177daab59d3cf6ae8c3e78a884a4e1941c2 It looks to be an unintentional change to the protocol, with the exception being thrown: An ex

Re: [VOTE] Apache Geode 1.10.0.RC1

There appears to be consensus that this is a critical fix. The following commit has been brought into release/1.10.0 as the critical fix for GEODE-7169: git cherry-pick -x aaa1378472ce0a8a05e0afabfdfc874e14fe13e6 GEODE-7169 has been marked as 'resolved in’ 1.10.0. 1.10.0.RC1 is no longer viabl

Re: [VOTE] Apache Geode 1.10.0.RC1

The 1.10.RC1 is being pulled for this change and we'll have an RC2 rolling out later today. -Dick On Mon, Sep 9, 2019 at 9:02 AM Dan Smith wrote: > +1 to getting the source build fix into 1.10. > > -Dan > > On Fri, Sep 6, 2019 at 5:58 PM Owen Nichols wrote: > > > +1 for catching the correct g

Re: [VOTE] Apache Geode 1.10.0.RC1

+1 to getting the source build fix into 1.10. -Dan On Fri, Sep 6, 2019 at 5:58 PM Owen Nichols wrote: > +1 for catching the correct grgit exception so Geode can compile from > src.tgz distribution. I might have gone further and just changed it to > catch Exception, but it looks like the GrGit

Re: [VOTE] Apache Geode 1.10.0.RC1

+1 for catching the correct grgit exception so Geode can compile from src.tgz distribution. I might have gone further and just changed it to catch Exception, but it looks like the GrGit project has been stable for the last 2 years

Re: [VOTE] Apache Geode 1.10.0.RC1

+1 to bringing the build-from-source name to 1.10 -1 to RC1 until then On Fri, Sep 6, 2019, 14:21 Owen Nichols wrote: > Hi Anthony, thank you for bringing your concern. > > If there is consensus from the Geode community that your proposed fix > satisfies the “critical fixes” rule, I will be hap

Re: [VOTE] Apache Geode 1.10.0.RC1

Hi Anthony, thank you for bringing your concern. If there is consensus from the Geode community that your proposed fix satisfies the “critical fixes” rule, I will be happy to bring it to the release/1.10.0 release branch. Regards Dick & Owen > On Sep 6, 2019, at 2:18 PM, Anthony Baker wrote:

Re: [VOTE] Apache Geode 1.10.0.RC1

Please pull aaa1378472ce0a8a05e0afabfdfc874e14fe13e6 into the release branch to fix the build problem. Anthony > On Sep 6, 2019, at 11:29 AM, Dick Cavender wrote: > > The 1.10.0 voting has been extended until Monday, September 9th at 3pm. > > To all- please update your 1.10.0 vote if/when yo

Re: [VOTE] Apache Geode 1.10.0.RC1

The 1.10.0 voting has been extended until Monday, September 9th at 3pm. To all- please update your 1.10.0 vote if/when your issue(s) have been resolved. There are still no -1 votes at this time. On Fri, Sep 6, 2019 at 9:32 AM Nabarun Nag wrote: > Hi Anthony, > > I had faced this issue in the cu

Re: [VOTE] Apache Geode 1.10.0.RC1

Hi Anthony, I had faced this issue in the current develop too. One way to get around it is to run ./gradlew spotlessApply independently before the build. Regards Naba On Fri, Sep 6, 2019 at 8:53 AM Anthony Baker wrote: > This seems to be a simple change to catch IllegalStateException instead

Re: [VOTE] Apache Geode 1.10.0.RC1

This seems to be a simple change to catch IllegalStateException instead of IllegalArgumentException in build.gradle. But I’m also getting a ton of spotless errors like: > Task :geode-cq:spotlessJava FAILED Step 'removeUnusedImports' found problem in 'geode-cq/src/test/java/org/apache/geode/cach

Re: [VOTE] Apache Geode 1.10.0.RC1

I ran into a problem while checking the release candidate. When I try to build from source I get this error: A problem occurred evaluating project ':geode-core'. > Could not create task ':writeBuildInfo'. > No .git directory found! The .buildinfo file looks correct, but the gradle scripts th

Re: [VOTE] Apache Geode 1.10.0.RC1

I think we should extend the vote in order to understand this issue better. Anthony > On Sep 6, 2019, at 12:41 AM, Ivan Godwin wrote: > > Hello, > > I don't know that this will be cause to hold anything up, but geode-native > has two integration tests failing when trying to perform Region::re

Re: [VOTE] Apache Geode 1.10.0.RC1

Hello, I don't know that this will be cause to hold anything up, but geode-native has two integration tests failing when trying to perform Region::remove(). This is the case for all platforms supported by native client. The two tests are testThinClientCallbackArg and testThinClientListenerCallback

Re: [VOTE] Apache Geode 1.10.0.RC1

Thank you Dan for the explanation. Regards Naba On Thu, Sep 5, 2019 at 4:34 PM Dan Smith wrote: > Hi Naba, > > This sanctioned-serializable stuff is not an issue. > > When you removed those files from sanctioned-geode-core-serializables, they > get rejected by the serialization filter. Look at

Re: [VOTE] Apache Geode 1.10.0.RC1

Hi Naba, This sanctioned-serializable stuff is not an issue. When you removed those files from sanctioned-geode-core-serializables, they get rejected by the serialization filter. Look at the error message you see when you remove them - it is failing to serialize a class that has a *nested* Evicti

Re: [VOTE] Apache Geode 1.10.0.RC1

Ah, ok. I think I see what you're asking about. I don't have an answer, but someone else such as Bruce could explain it. /Users/klund/dev/geode3 [610]$ diff geode-core/src/main/resources/org/apache/geode/internal/sanctioned-geode-core-serializables.txt geode-core/build/integrationTest/actualSerial

Re: [VOTE] Apache Geode 1.10.0.RC1

Hi Kirk, The test does not fail. When you run the test (testSerializable) it creates a list of serializable classes and puts it in the actualSerializables.dat file and them compares if all the classes listed are present in the sanctioned-geode-core-serializables.txt. If we did not change any seria

Re: [VOTE] Apache Geode 1.10.0.RC1

Hi Naba, I failed to reproduce the problem you reported on Mac OS, and our pipeline didn't fail this test. What OS are you running integrationTest on? Here's the steps I followed: 1) checkout tag rel/v1.10.0.RC1 $ git checkout tags/rel/v1.10.0.RC1 2) clean, then build with unit tests $ ./gradl

Re: [VOTE] Apache Geode 1.10.0.RC1

+1 - Built from source and ran unit tests - Used GFSH to create a locator and server and do some puts/gets - Checked version in GFSH - Built and ran all of the examples - Verified SHAs and signatures - Aaron On Thu, Sep 5, 2019 at 10:16 AM Nabarun Nag wrote: > Hello, > > I was

Re: [VOTE] Apache Geode 1.10.0.RC1

Hello, I was able to notice that after running the testSerializable JUnit test, the generated actualSerializables.dat and the sanctioned-geode-core-serializables.txt do not match. There are certain classes mentioned in sanctioned-geode-core-serializables.txt that are not present in actualSerializa

Re: [VOTE] Apache Geode 1.10.0.RC1

+1 to release 1.10.0.RC1. Downloaded and reviewed contents of artifacts. Reviewed Manifest of geode dependency jar. Used GFSH to start locator and server. On Wed, Sep 4, 2019 at 4:14 PM Dick Cavender wrote: > We manually signed the apache-geode-1.10.0-src.tgz dist and uploaded the > asc file. >

Re: [VOTE] Apache Geode 1.10.0.RC1

We manually signed the apache-geode-1.10.0-src.tgz dist and uploaded the asc file. Unclear on why this is no longer automatically generated as part of the build step as 1.9.1 it was generated correctly. We have worked around it in the prepare_rc.sh adding a check for it going forward and generatin

Re: [VOTE] Apache Geode 1.10.0.RC1

I don't see a .asc signature file for apache-geode-1.10.0-src.tgz. Did we miss that signature file somehow? -Dan On Wed, Sep 4, 2019 at 9:33 AM Dick Cavender wrote: > The apache-geode-native-1.10.0-src.tar.gz dist has been fixed in RC1 and > can be found at: https://dist.apache.org/repos/dist/d

Re: [VOTE] Apache Geode 1.10.0.RC1

The apache-geode-native-1.10.0-src.tar.gz dist has been fixed in RC1 and can be found at: https://dist.apache.org/repos/dist/dev/geode/1.10.0.RC1/ Please continue to review RC1 as a viable 1.10 RC. The voting deadline remains 3PM PST Thursday Sept 5th. -Dick On Tue, Sep 3, 2019 at 3:09 PM Dan Sm

Re: [VOTE] Apache Geode 1.10.0.RC1

Everything but the missing native source looks good. If we can fix that, I'll +1 this RC. -Dan On Tue, Sep 3, 2019 at 2:26 PM Dan Smith wrote: > -1 It looks like this RC is also missing the native source, just like > 1.9.1.RC3. The tar file is there, but it is empty. > > -Dan > > On Fri, Aug 30

Re: [VOTE] Apache Geode 1.10.0.RC1

-1 It looks like this RC is also missing the native source, just like 1.9.1.RC3. The tar file is there, but it is empty. -Dan On Fri, Aug 30, 2019 at 2:06 PM Dick Cavender wrote: > Hello Geode dev community, > > This is a release candidate for Apache Geode, version 1.10.0.RC1. > Thanks to all t

Re: [VOTE] Apache Geode 1.10.0.RC1

+1 On Fri, Aug 30, 2019 at 10:46 PM Dave Barnes wrote: > +1 > Checked the docs: Successfully built AND viewed the Geode User Guide and > the Javadocs. > > On Fri, Aug 30, 2019 at 2:32 PM Jinmei Liao wrote: > > > + 1 verified the management v2 api is available by default and list of > rest > > e

Re: [VOTE] Apache Geode 1.10.0.RC1

+1 Checked the docs: Successfully built AND viewed the Geode User Guide and the Javadocs. On Fri, Aug 30, 2019 at 2:32 PM Jinmei Liao wrote: > + 1 verified the management v2 api is available by default and list of rest > end points. > > On Fri, Aug 30, 2019 at 2:06 PM Dick Cavender > wrote: > >

Re: [VOTE] Apache Geode 1.10.0.RC1

+ 1 verified the management v2 api is available by default and list of rest end points. On Fri, Aug 30, 2019 at 2:06 PM Dick Cavender wrote: > Hello Geode dev community, > > This is a release candidate for Apache Geode, version 1.10.0.RC1. > Thanks to all the community members for their contribu