Re: [DISCUSS] removal of geode-json module

2019-03-18 Thread Bruce Schuchardt
Ah, I missed that exclusion.  After removing it I was able to revert other build.gradle changes and everything seems to be working fine.  Thanks Dan On 3/18/19 11:38 AM, Dan Smith wrote: Huh, it looks like org.skyscreamer.jsonassert.JSONAssert is actually dependent that vaadin artifact anyway,

Re: [DISCUSS] removal of geode-json module

2019-03-18 Thread Dan Smith
Huh, it looks like org.skyscreamer.jsonassert.JSONAssert is actually dependent that vaadin artifact anyway, but we *excluded* it our geode-junit build file! That's why you are getting a runtime error. Maybe just remove the exclusion. >From geode-junit: compile('org.skyscreamer:jsonassert') { ex

re: [DISCUSS] removal of geode-json module

2019-03-18 Thread Bruce Schuchardt
I don't want to spend a lot more time on the removal of the geode-json module.  I'm going to delete it and leave the geode-web-api test dependent on the vaadin implementation of org.json. I still haven't been able to run the geode-pulse uiTests.  I'm going to leave that module dependent on the

Re: [DISCUSS] removal of geode-json module

2019-03-18 Thread Bruce Schuchardt
Hi Udo As I said, org.json is not used in the Geode runtime anymore but there are test dependencies in geode-pulse and geode-web-api. I've removed the dependency in geode-pulse but no-one seems to know how to run those tests so I can't verify that my changes are correct. Geode-web-api (RestA

Re: [DISCUSS] removal of geode-json module

2019-03-18 Thread Bruce Schuchardt
Hi Dan The dependency is through a Spring framework testing package used in RestAccessControllerTest.  Maybe there are others but this is the one I've focused on.  I tried replacing the code comparing JSON documents with Jackson ObjectMapper JsonNode comparisons but it didn't work. java.l

Re: [DISCUSS] removal of geode-json module

2019-03-18 Thread Bruce Schuchardt
Yeah, I saw that it has org.json packaging on github but if you try to use openjson from a maven repo it's packaged as com.github.openjson Downloads> jar -tf ./openjson-1.0.10.jar META-INF/MANIFEST.MF META-INF/ com/ com/github/ com/github/openjson/ META-INF/maven/ META-IN

Re: [DISCUSS] removal of geode-json module

2019-03-15 Thread Anthony Baker
We cannot use code licensed under the JSON.org license—it’s Category X [1]. There is an alternative [2] from an ASF member that was the basis for geode-json. Can we use that? The packaging looks like org.json to me. Anthony [1] https://www.apache.org/legal/resolved.html#category-x [2] https:/

Re: [DISCUSS] removal of geode-json module

2019-03-15 Thread Robert Houghton
sure vaadin and geose-json are VERY similar... On Fri, Mar 15, 2019, 16:32 Dan Smith wrote: > Here's the original legal ticket - > https://issues.apache.org/jira/browse/LEGAL-349. It does seem kinda fuzzy. > > What error are you getting if you remove geode-json? I don't see org.json > anywhere i

Re: [DISCUSS] removal of geode-json module

2019-03-15 Thread Dan Smith
Here's the original legal ticket - https://issues.apache.org/jira/browse/LEGAL-349. It does seem kinda fuzzy. What error are you getting if you remove geode-json? I don't see org.json anywhere in the dependenies of geode-web-api: ./gradlew geode-web-api:dependencies I also found this thing - whic

Re: [DISCUSS] removal of geode-json module

2019-03-15 Thread Bruce Schuchardt
There is a lengthy discussion about the org.json license & Apache here: https://lwn.net/Articles/707510/ There is a precursor to open-json that I've successfully used to test the geode-web-api module described here: http://stackoverflow.com/a/34418410/2171120 On 3/15/19 2:06 PM, Bruce Schuch

Re: [DISCUSS] removal of geode-json module

2019-03-15 Thread Udo Kohlmeyer
IMO, I think it would better serve the project if were to remove it completely and replace it with jackson. On 3/15/19 14:06, Bruce Schuchardt wrote: I've removed use of geode-json in non-test code and I'd like to remove it completely and just add a dependency on a org.json package in a Maven