Re: [DISCUSS] Framework for concurrency tests

2017-09-15 Thread Jason Huynh
+1 to Dan's Changes but also +1 to Galen's suggestion. JPF looks like it might take a bit to run all the different states even for a small interleaving of code (maybe we can tune/configure it though). Or we can mark these as a different category and not run as a "UnitTest" On Fri, Sep 15, 2017 a

Re: [DISCUSS] Framework for concurrency tests

2017-09-15 Thread Jacob Barrett
What? You don’t think Travis can run these fast? > On Sep 15, 2017, at 2:07 PM, Galen O'Sullivan wrote: > > +1 This is great! I'll take a look at your PR when I get the time. > > We may want to think carefully about how often we run these tests, because > unlike regular unit tests, they will t

Re: [DISCUSS] Framework for concurrency tests

2017-09-15 Thread Galen O'Sullivan
+1 This is great! I'll take a look at your PR when I get the time. We may want to think carefully about how often we run these tests, because unlike regular unit tests, they will take forever to run. On Fri, Sep 15, 2017 at 1:42 PM, Michael William Dodge wrote: > +1 for unit tests for multithre

Re: [DISCUSS] Framework for concurrency tests

2017-09-15 Thread Michael William Dodge
+1 for unit tests for multithreaded code. High fives to Dan. Sarge > On 15 Sep, 2017, at 12:08, Dan Smith wrote: > > Hi Geode devs, > > I've been messing around with an open source tool called Java > Pathfinder for writing tests of multithreaded code. Java Pathfinder is > a special JVM which

Re: [DISCUSS] Framework for concurrency tests

2017-09-15 Thread Jacob Barrett
Love it! See my comments in your pull request. On Fri, Sep 15, 2017 at 12:08 PM Dan Smith wrote: > Hi Geode devs, > > I've been messing around with an open source tool called Java > Pathfinder for writing tests of multithreaded code. Java Pathfinder is > a special JVM which among other things tr