Here's some food for thought on creating coding standards...
1. You can't please everyone all of the time or in all aspects and this
becomes "Hero" driven or a "holy war"
2. Creating a custom standard is very time/resource consuming and (see #1)
3. Adopting an objectively maintained industry coding
+1 to having a recommended reading list. At first glance, the SEI standard
seems like an extremely useful resource, but I am hesitant to adopt it as
our "coding standard" without carefully reading all the way through it. I
would, however, be comfortable adding it to a recommended reading list.
- A
I like the idea of a recommended reading list for Geode contributors.
My concerns around adopting broad standards and guidelines that can’t be
automatically checked & applied are twofold:
a) what is the policy regarding existing code? Is every PR going forward
expected to bring every file it
Maybe we need a "recommended reading" list more than we need a
non-enforceable standard. The Oracle wiki has a lot of good
correct/incorrect examples that people could learn from if they take the
time to read through it all.
On 6/24/19 3:15 PM, Kirk Lund wrote:
Java is complicated and Apach
> Is there an entry in the Coding Standard's Rules section that you feel is
irrelevant or incorrect? Please pick an example with a link to it so we can
discuss it.
I haven't seen any rules in there that I think are irrelevant or incorrect.
My reasoning is a little different from that:
I think ther
Java is complicated and Apache Geode is complicated, hence it's a large
Coding Standard. *Effective Java* is similarly *large* if you compare it to
the *Google Java Style Guide*.
The "*rules*" are "*guidelines*" -- I think you're being too literal. Also,
please remember what I said:
I'm not propo
>
> What did you like about the SEI rules you suggested? I’m wondering why
> _that_ one versus all the others in the universe?
For me, the book The CERT Oracle Secure Coding Standard for Java is almost
as essential as Effective Java in my library of Java books. As far I know,
there are no other
Hi Kirk,
I think having a coding standard that goes beyond a formatting style guide
is a great idea. There are many interesting things in the SEI CERT
standard. However, it's also massive. I see 13 rules just about methods.
Yet some guidelines that would be most important to me like limiting metho
What did you like about the SEI rules you suggested? I’m wondering why _that_
one versus all the others in the universe?
Anthony
> On Jun 24, 2019, at 2:15 PM, Kirk Lund wrote:
>
> Apache Geode has a Code Style Guide [1] which is currently defined as
> following the Google Java Style Guide [
