: Wednesday, December 16, 2020 at 10:47 AM
To: dev@geode.apache.org
Subject: Re: [DISCUSS] Adding CODEOWNERS to Apache Geode
Hi Owen,
Thanks for pushing this forward! Given that a lot of folks are on holiday -
maybe sometime in January might be a better time to merge this to develop to
give everyone a
_
From: Owen Nichols
Sent: Tuesday, December 15, 2020 3:00 PM
To: dev@geode.apache.org
Subject: Re: [DISCUSS] Adding CODEOWNERS to Apache Geode
Given the support this is receiving, it looks like the next step is to bring
CODEOWNERS to develop.
https://nam04.safelinks.protection.outlook.
, December 14, 2020 at 7:25 AM
To: dev@geode.apache.org
Subject: Re: [DISCUSS] Adding CODEOWNERS to Apache Geode
I've self-nominated for redis, management and security.
--Jens
On 12/14/20, 1:44 AM, "Owen Nichols" wrote:
Thanks @Dave and @Karen for volunteering as code owners!
Two or more volunteers on each line is desirable.
From: Owen Nichols
Date: Monday, December 7, 2020 at 4:53 PM
To: dev@geode.apache.org
Subject: Re: [DISCUSS] Adding CODEOWNERS to Apache Geode
Let’s keep this simple. If you’re nominating yourself, just commit to the
branch
has to go through the normal PR process back to the
develop branch.
-Robert
From: Jens Deppe
Date: Monday, December 7, 2020 at 11:43 AM
To: dev@geode.apache.org
Subject: Re: [DISCUSS] Adding CODEOWNERS to Apache Geode
Should we just be adding to Owen's PR?
If everyone creates their own PR
a formal PR to bring it to
develop? We can always fill in any missing code-owners after Dec 14 via PR
against develop.
From: Robert Houghton
Date: Monday, December 7, 2020 at 1:38 PM
To: dev@geode.apache.org
Subject: Re: [DISCUSS] Adding CODEOWNERS to Apache Geode
To be honest, I hadn’t
back to the
develop branch.
-Robert
From: Jens Deppe
Date: Monday, December 7, 2020 at 11:43 AM
To: dev@geode.apache.org
Subject: Re: [DISCUSS] Adding CODEOWNERS to Apache Geode
Should we just be adding to Owen's PR?
If everyone creates their own PR we'll probably end up with a bunc
8:56 PM
To: dev@geode.apache.org
Subject: Re: [DISCUSS] Adding CODEOWNERS to Apache Geode
It looks like the discussion period ended Nov 25 with all comments in
support, so next phase is populating the proposed codeowners file. @Robert how
long do we have to populate this before you plan
on
14 December?
From: Owen Nichols
Date: Tuesday, December 1, 2020 at 8:56 PM
To: dev@geode.apache.org
Subject: Re: [DISCUSS] Adding CODEOWNERS to Apache Geode
It looks like the discussion period ended Nov 25 with all comments in support,
so next phase is populating the proposed codeowners
feature/introduce-codeowners
branch to nominate myself as a code owner for areas I feel qualified to own.
[1] https://github.com/apache/geode/pull/5802
From: Xiaojian Zhou
Date: Friday, November 20, 2020 at 11:06 AM
To: dev@geode.apache.org
Subject: Re: [DISCUSS] Adding CODEOWNERS to Apache
DISCUSS] Adding CODEOWNERS to Apache Geode
+1
I think we as a project will need to iterator on the code owners as well as
the process for code owners. But this is a model that has been adopted by a
number of OSS projects both within and outside of Apache. I like that it
provides visibilit
Baker
Sent: Thursday, November 19, 2020 17:55
To: dev@geode.apache.org
Subject: Re: [DISCUSS] Adding CODEOWNERS to Apache Geode
+1
I think we as a project will need to iterator on the code owners as well as the
process for code owners. But this is a model that has been adopted by a number
o
get reviewers by default, but when the draft transitions
> to ‘ready’, then the owners are requested to review.
>
>
>From: Ernie Burghardt
>Date: Thursday, November 19, 2020 at 9:56 AM
> To: dev@geode.apache.org
>Subject: Re: [DISCUSS] Adding CODEOWNERS to Apache Geo
rsday, November 19, 2020 at 9:56 AM
To: dev@geode.apache.org
Subject: Re: [DISCUSS] Adding CODEOWNERS to Apache Geode
Does GitHub allow us to limit this automated action to non-DRAFT PRs?
On 11/18/20, 8:28 PM, "Owen Nichols" wrote:
+1 This will greatly i
Hi Ernie,
DRAFT PRs do not get reviewers by default, but when the draft transitions to
‘ready’, then the owners are requested to review.
From: Ernie Burghardt
Date: Thursday, November 19, 2020 at 9:56 AM
To: dev@geode.apache.org
Subject: Re: [DISCUSS] Adding CODEOWNERS to Apache Geode
Does
enforced (you can’t review your own PR)
* Feel free to start PRs or changes to `features/introduce_codeowners`
From: Owen Nichols
Date: Wednesday, November 18, 2020 at 8:28 PM
To: dev@geode.apache.org
Subject: Re: [DISCUSS] Adding CODEOWNERS to Apache Geode
+1 This will greatly improve
Does GitHub allow us to limit this automated action to non-DRAFT PRs?
On 11/18/20, 8:28 PM, "Owen Nichols" wrote:
+1 This will greatly improve the experience for contributors. Instead of
an intimidating empty list of reviewers when you submit a PR (and no ability to
add reviewers, if y
+1 This will greatly improve the experience for contributors. Instead of an
intimidating empty list of reviewers when you submit a PR (and no ability to
add reviewers, if you’re not a committer), it will be great to already have at
least two reviewers automagically assigned.
I have a small con
18 matches
Mail list logo
