Re: [DISCUSS]: SSL and jdk11

2018-10-24 Thread Jinmei Liao
Looks like we have a consensus on this one. I will implement the 2nd option then. On Wed, Oct 24, 2018 at 11:59 AM Anthony Baker wrote: > If possible I don’t think we should have any code that is conditional > based on TLS version. > > Anthony > > > > On Oct 24, 2018, at 11:41 AM, Owen Nichols

Re: [DISCUSS]: SSL and jdk11

2018-10-24 Thread Anthony Baker
If possible I don’t think we should have any code that is conditional based on TLS version. Anthony > On Oct 24, 2018, at 11:41 AM, Owen Nichols wrote: > > If Geode code is tightly coupled to the TLS protocol version, might be good > to have some tests that explicitly test how Geode handles

Re: [DISCUSS]: SSL and jdk11

2018-10-24 Thread Owen Nichols
If Geode code is tightly coupled to the TLS protocol version, might be good to have some tests that explicitly test how Geode handles both TLSv1.2 and TLSv1.3 connections, when running under Java version that supports TLSv1.3 The code example you gave looks like it is just debug logging that is

Re: [DISCUSS]: SSL and jdk11

2018-10-24 Thread Dan Smith
(2) seems like the only reasonable option. We don't want to get stuck not being able to support newer TLS versions! -Dan On Wed, Oct 24, 2018 at 11:23 AM Jinmei Liao wrote: > Most of our SSL tests failed with jdk11 because jdk11 includes an > implementation of TLS1.3 protocol, so if tcpServer i