I think it's useful for contact those that feel compelled to hide their email
addresses. If there is an email address you can surely use that directly. I
have used the commenting feature a few times and like it because it puts the
comment with the code making it dead clear what I am talking abou
Since most folks don't even notice they've been requested to review a PR, I
don't have high confidence that they'll notice a notification about a
comment on a past commit. Seems sort of useful though. Thank you!
On Thu, Jun 18, 2020 at 3:53 PM Owen Nichols wrote:
> Perhaps a little-known feature
Perhaps a little-known feature of GitHub: you can comment on commits too, not
just on PRs. For example:
https://github.com/apache/geode/commit/d82e30d3dd50e3983c332063c41915e97aca721a
On 6/18/20, 3:48 PM, "Kirk Lund" wrote:
I'm not sure what you're talking about Jake (PRs?). I'm talking
I'm not sure what you're talking about Jake (PRs?). I'm talking about
commits that are already on develop.
For example, if someone adds a new dunit test that turns out to be very
flaky, I'd like to find out from the git log who authored it and send them
an email directly (privately) and I have no
I think that is a fair point.
On 6/18/20, 3:43 PM, "Jacob Barrett" wrote:
Regardless of the email address issue, you can go to the commit and make
comments and @johndoe and they will get a notification.
-Jake
> On Jun 18, 2020, at 10:31 AM, Kirk Lund wrote:
>
> I gues
Regardless of the email address issue, you can go to the commit and make
comments and @johndoe and they will get a notification.
-Jake
> On Jun 18, 2020, at 10:31 AM, Kirk Lund wrote:
>
> I guess my main point is that I don't like private emails in OSS commit
> messages.
>
> Author: John Do
Hi All,
Just my opinion here, but I think that if you commit something that breaks CI,
I should be able e-mail you at the email address on your commit.
Thanks,
Mark
On 6/18/20, 10:31 AM, "Kirk Lund" wrote:
I guess my main point is that I don't like private emails in OSS commit
messa
I guess my main point is that I don't like private emails in OSS commit
messages.
Author: John Doe
If there's a problem with a commit made by John Doe and he doesn't work for
Pivotal, then I have no idea how to contact him directly to discuss the
commit. If I visit github.com/johndoe, there's no
Hi Kirk,
I think it is also now in the privacy setting in GitHub for anyone who wants to
keep emails private. [https://github.com/settings/emails :
https://github.com/settings/emails ]
This setting is needed for web based git operations like squash merging PRs etc.
In GitHub:
"Keep my email a
