Re: Question about version checks inside fromData method in GatewaySenderEventImpl

2020-05-19 Thread Bruce Schuchardt
t; ____ > From: Ju@N > Sent: Tuesday, May 19, 2020 2:54 PM > To: dev@geode.apache.org > Subject: Re: Question about version checks inside fromData method in > GatewaySenderEventImpl > > Hello Alberto, > > It looks li

Re: Question about version checks inside fromData method in GatewaySenderEventImpl

2020-05-19 Thread Ju@N
gt; Thanks, > > -Alberto > > > > From: Ju@N > Sent: Tuesday, May 19, 2020 2:54 PM > To: dev@geode.apache.org > Subject: Re: Question about version checks inside fromData method in > GatewaySenderEventImpl > > Hello Alberto, > > It

Re: Question about version checks inside fromData method in GatewaySenderEventImpl

2020-05-19 Thread Alberto Gomez
From: Ju@N Sent: Tuesday, May 19, 2020 2:54 PM To: dev@geode.apache.org Subject: Re: Question about version checks inside fromData method in GatewaySenderEventImpl Hello Alberto, It looks like the property *isConcurrencyConflict* was added as part of *GEODE-3967* [1] and this was released as

RE: Question about version checks inside fromData method in GatewaySenderEventImpl

2020-05-19 Thread Alberto Bustamante Reyes
And the other one is using ifs to check the versions. But this method is mixing both of them. BR/ Alberto B. De: Ju@N Enviado: martes, 19 de mayo de 2020 14:54 Para: dev@geode.apache.org Asunto: Re: Question about version checks inside fromData method in Ga

Re: Question about version checks inside fromData method in GatewaySenderEventImpl

2020-05-19 Thread Ju@N
Hello Alberto, It looks like the property *isConcurrencyConflict* was added as part of *GEODE-3967* [1] and this was released as part of Geode 1.9.0; that seems to the reason why the check is in place: if we get an instance of *GatewaySenderEventImpl* from a member running a version higher than 1.

Question about version checks inside fromData method in GatewaySenderEventImpl

2020-05-19 Thread Alberto Gomez
Hi, Looking at the fromData method of GatewaySenderEventImpl I see that it contains a conditional reading of the isConcurrencyConflict when version is greater than Geode 1.9.0 one. See below: @Override public void fromData(DataInput in, DeserializationContext context) throws IOExcepti