Re: Proposal to restore Pulse logging in support/1.12

2020-04-24 Thread Dale Emery
Merged into support/1.12. Thanks all. > On Apr 24, 2020, at 3:25 PM, Mark Bretl wrote: > > +1 > > On Fri, Apr 24, 2020 at 3:07 PM Owen Nichols wrote: > >> +1 >> >>> On Apr 24, 2020, at 3:06 PM, Jinmei Liao wrote: >>> >>> +1 >>> >>> On Fri, Apr 24, 2020 at 2:53 PM Anthony Baker wrote: >>>

Re: Proposal to restore Pulse logging in support/1.12

2020-04-24 Thread Mark Bretl
+1 On Fri, Apr 24, 2020 at 3:07 PM Owen Nichols wrote: > +1 > > > On Apr 24, 2020, at 3:06 PM, Jinmei Liao wrote: > > > > +1 > > > > On Fri, Apr 24, 2020 at 2:53 PM Anthony Baker wrote: > > > >> +1 > >> > >>> On Apr 24, 2020, at 2:46 PM, Dale Emery wrote: > >>> > >>> During the cleanup of the

Re: Proposal to restore Pulse logging in support/1.12

2020-04-24 Thread Owen Nichols
+1 > On Apr 24, 2020, at 3:06 PM, Jinmei Liao wrote: > > +1 > > On Fri, Apr 24, 2020 at 2:53 PM Anthony Baker wrote: > >> +1 >> >>> On Apr 24, 2020, at 2:46 PM, Dale Emery wrote: >>> >>> During the cleanup of the gradle build and logging, the Pulse webapp >> lost its slf4j implementation.

Re: Proposal to restore Pulse logging in support/1.12

2020-04-24 Thread Jinmei Liao
+1 On Fri, Apr 24, 2020 at 2:53 PM Anthony Baker wrote: > +1 > > > On Apr 24, 2020, at 2:46 PM, Dale Emery wrote: > > > > During the cleanup of the gradle build and logging, the Pulse webapp > lost its slf4j implementation. As a result, Pulse stopped writing log files. > > > > I’ve restored Pul

Re: Proposal to restore Pulse logging in support/1.12

2020-04-24 Thread Anthony Baker
+1 > On Apr 24, 2020, at 2:46 PM, Dale Emery wrote: > > During the cleanup of the gradle build and logging, the Pulse webapp lost its > slf4j implementation. As a result, Pulse stopped writing log files. > > I’ve restored Pulse logging in the develop branch. > > I would like to restore it in

Proposal to restore Pulse logging in support/1.12

2020-04-24 Thread Dale Emery
During the cleanup of the gradle build and logging, the Pulse webapp lost its slf4j implementation. As a result, Pulse stopped writing log files. I’ve restored Pulse logging in the develop branch. I would like to restore it in support/1.12. I’ve created a PR: https://github.com/apache/geode/pul