Re: Proposal: Lucene indexing/searching for nested objects

2017-07-20 Thread Jacob Barrett
Good point! Sounds good then. Sent from my iPhone > On Jul 20, 2017, at 11:15 AM, Dan Smith wrote: > >> On Thu, Jul 20, 2017 at 10:57 AM, Jacob Barrett wrote: >> >> I really feel like an annotation would make the most sense. How likely is >> it that the object could not be annotated or the se

Re: Proposal: Lucene indexing/searching for nested objects

2017-07-20 Thread Dan Smith
On Thu, Jul 20, 2017 at 10:57 AM, Jacob Barrett wrote: > I really feel like an annotation would make the most sense. How likely is > it that the object could not be annotated or the serializer for the object > is not tightly coupled with the object? Having to map objects to > serializers external

Re: Proposal: Lucene indexing/searching for nested objects

2017-07-20 Thread Jacob Barrett
I really feel like an annotation would make the most sense. How likely is it that the object could not be annotated or the serializer for the object is not tightly coupled with the object? Having to map objects to serializers externally then becomes a lot more complicated to keep consistent. Se

Re: Proposal: Lucene indexing/searching for nested objects

2017-07-20 Thread Dan Smith
This proposal doesn't really talk about XML or gfsh support. The XML should probably just be a nested xml element, like this. It should have the same support for declarables that other callbacks in the xml do. com.mycompany.MySerializer The gfsh command to create an index should also accep

Re: Proposal: Lucene indexing/searching for nested objects

2017-07-18 Thread Dan Smith
I think this LuceneSerializer API needs a slight tweak. In order to implement the proposed FlatFormatSerializer, the serializer needs access to the index configuration to see what fields the user wants to index. We should also pass the LuceneIndex to the serializer. public interface LuceneSerializ

Re: Proposal: Lucene indexing/searching for nested objects

2017-07-13 Thread Dan Smith
On Thu, Jul 13, 2017 at 11:26 AM, Jacob Barrett wrote: > Collections are really tough in Lucene because you have to flatten the > document. I struggled against it for some time on a project a few years ago > and ultimately decided to index the relationships separately and then merge > the results

Re: Proposal: Lucene indexing/searching for nested objects

2017-07-13 Thread Jacob Barrett
Collections are really tough in Lucene because you have to flatten the document. I struggled against it for some time on a project a few years ago and ultimately decided to index the relationships separately and then merge the results. Sent from my iPhone > On Jul 13, 2017, at 11:13 AM, Dan S

Re: Proposal: Lucene indexing/searching for nested objects

2017-07-13 Thread Dan Smith
+1 Looks good. I think we should consider adding support for collections as well, but that doesn't have to be in the first cut. -Dan On Wed, Jul 12, 2017 at 10:37 AM, Diane Hardman wrote: > The Geode 1.2.0 release includes Lucene text search fully integrated and > tested (no longer experimental

Proposal: Lucene indexing/searching for nested objects

2017-07-12 Thread Diane Hardman
The Geode 1.2.0 release includes Lucene text search fully integrated and tested (no longer experimental). We are now proposing enhancements to improve Lucene usability in Geode. Some Geode users create data models that include nested and complex objects. The current Geode Lucene integration suppor