Re: Problem with LGTM on geode-native pull request

2019-08-02 Thread Blake Bender
FWIW, I pushed the fix yesterday afternoon, so if you rebase to pick it up LGTM will pass. Thanks for your patience. Blake On Thu, Aug 1, 2019 at 9:36 AM Alberto Gomez wrote: > Having put it this way, I agree with you guys ;-) > > Thanks, > > -Alberto > > On 1/8/19 18:02, Blake Bender wrote:

Re: Problem with LGTM on geode-native pull request

2019-08-01 Thread Alberto Gomez
Having put it this way, I agree with you guys ;-) Thanks, -Alberto On 1/8/19 18:02, Blake Bender wrote: > I agree with Jake on this one. From a bookkeeping perspective, what I'd > like to see in the history is a single commit that fixes all the LGTM > issues, and your fix for this bug in a sepa

Re: Problem with LGTM on geode-native pull request

2019-08-01 Thread Blake Bender
I agree with Jake on this one. From a bookkeeping perspective, what I'd like to see in the history is a single commit that fixes all the LGTM issues, and your fix for this bug in a separate commit. I have a copy of your .yml changes on my "fix LGTM" branch already, please back that change out and

Re: Problem with LGTM on geode-native pull request

2019-08-01 Thread Alberto Gomez
Hi, I would not back out the LGTM changes added in the PR as they are necessary. - Alberto On 31/7/19 23:46, Jacob Barrett wrote: > I would say for this PR, back out the LGTM changes and just move forward > ignoring the LGTM results.

Re: Problem with LGTM on geode-native pull request

2019-07-31 Thread Jacob Barrett
I would say for this PR, back out the LGTM changes and just move forward ignoring the LGTM results. > On Jul 31, 2019, at 12:14 PM, Blake Bender wrote: > > Still looking into this, don’t expect to have a resolution today > necessarily. I turned off network support in our build of Xerces, since

Re: Problem with LGTM on geode-native pull request

2019-07-31 Thread Blake Bender
Still looking into this, don’t expect to have a resolution today necessarily. I turned off network support in our build of Xerces, since we don’t use it, and that got rid of some, but not all, of the unresolved references. I’ll have to get hold of the LGTM Docker image to see what’s going on with

Re: Problem with LGTM on geode-native pull request

2019-07-31 Thread Blake Bender
Linking errors look like (perhaps among other things) missing symbols for libcurl(?) needed by the Xerces library, which was recently added. We build internally against RHEL 7, Ubuntu, Windows, and develop on MacBook Pros, but it appears LGTM is attempting to build on some other OS flavor and mayb

Re: Problem with LGTM on geode-native pull request

2019-07-31 Thread Alberto Gomez
Hi, I updated the .lgtm.yml file so that the right version of Apache Geode is downloaded and now I get errors in the linking process about some symbols not found. Could anybody help with this? Thanks, Alberto On 30/7/19 15:50, Jacob Barrett wrote: > Yes, that seems to be the issue. Can you u

Re: Problem with LGTM on geode-native pull request

2019-07-30 Thread Jacob Barrett
Yes, that seems to be the issue. Can you update the lgtm.yml and push to your branch. Thanks, Jake > On Jul 30, 2019, at 5:09 AM, Alberto Gomez wrote: > > Hi, > > I am getting a failure on the C/C++ LGTM analysis over a recently > created pull request on geode-native: > https://github.com/

Problem with LGTM on geode-native pull request

2019-07-30 Thread Alberto Gomez
Hi, I am getting a failure on the C/C++ LGTM analysis over a recently created pull request on geode-native: https://github.com/apache/geode-native/pull/504 I have noticed that this it the first PR on geode-native having LGTM analysis. There is a .lgtm.yml on the repo that does not seem up to