Re: Merging GEODE-6424 into release/1.9.0

2019-02-22 Thread Sai Boorlagadda
+1 for bringing in this fix to 1.9.0 (esp if this fixes a race condition that is introduced by GEODE-6424 which is already merged). On Fri, Feb 22, 2019 at 10:56 AM Helena Bales wrote: > Does anyone have an issue with merging > https://github.com/apache/geode/pull/3220 to the 1.9.0 release branc

Re: Merging GEODE-6424 into release/1.9.0

2019-02-22 Thread Helena Bales
Does anyone have an issue with merging https://github.com/apache/geode/pull/3220 to the 1.9.0 release branch? It fixes a race condition introduced by the fix to GEODE-6424 that was approved above. It is critical that we keep the fix to GEODE-6424 in 1.9.0 in order to be able to proceed with benchm

Re: Merging GEODE-6424 into release/1.9.0

2019-02-20 Thread Jacob Barrett
My bad! Sorry! > On Feb 20, 2019, at 3:22 PM, Sai Boorlagadda > wrote: > > Jake, > > release branch build seems broken due to spotless changes. > > https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-release-1-9-0-main > > Sai > >> On Wed, Feb 20, 2019 at 2:59 PM Jacob Barrett

Re: Merging GEODE-6424 into release/1.9.0

2019-02-20 Thread Sai Boorlagadda
Jake, release branch build seems broken due to spotless changes. https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-release-1-9-0-main Sai On Wed, Feb 20, 2019 at 2:59 PM Jacob Barrett wrote: > Done! > > > On Feb 20, 2019, at 1:22 PM, Udo Kohlmeyer wrote: > > > > +1, Go,Go,GO!

Re: Merging GEODE-6424 into release/1.9.0

2019-02-20 Thread Jacob Barrett
Done! > On Feb 20, 2019, at 1:22 PM, Udo Kohlmeyer wrote: > > +1, Go,Go,GO!! > >> On 2/20/19 12:24, Jacob Barrett wrote: >> Anyone have issue with merging >> https://issues.apache.org/jira/browse/GEODE-6424 >> into release/1.9.0? >> >> Witho

Re: Merging GEODE-6424 into release/1.9.0

2019-02-20 Thread Udo Kohlmeyer
+1, Go,Go,GO!! On 2/20/19 12:24, Jacob Barrett wrote: Anyone have issue with merging https://issues.apache.org/jira/browse/GEODE-6424 into release/1.9.0? Without it we will have to wait for the next release before we can have meaningful basel

Re: Merging GEODE-6424 into release/1.9.0

2019-02-20 Thread Dan Smith
+1 On Wed, Feb 20, 2019 at 12:24 PM Jacob Barrett wrote: > Anyone have issue with merging > https://issues.apache.org/jira/browse/GEODE-6424 < > https://issues.apache.org/jira/browse/GEODE-6424> into release/1.9.0? > > Without it we will have to wait for the next release before we can have > mea

Re: Merging GEODE-6424 into release/1.9.0

2019-02-20 Thread Owen Nichols
My vote: Let’s get this into 1.9 On Wed, Feb 20, 2019 at 12:25 PM Jacob Barrett wrote: > Anyone have issue with merging > https://issues.apache.org/jira/browse/GEODE-6424 < > https://issues.apache.org/jira/browse/GEODE-6424> into release/1.9.0? > > Without it we will have to wait for the next re

Merging GEODE-6424 into release/1.9.0

2019-02-20 Thread Jacob Barrett
Anyone have issue with merging https://issues.apache.org/jira/browse/GEODE-6424 into release/1.9.0? Without it we will have to wait for the next release before we can have meaningful baselines for function and query benchmarks. Without this fix