Re: How to setup IntelliJ

2018-07-19 Thread Dan Smith
On Wed, Jul 18, 2018 at 10:51 PM, Jacob Barrett wrote: > Checkout the latest from develop. > Configure IntelliJ Build / Build Tools / Gradle / Uncheck "Create separate > module per source set". > Refresh the Gradle config (or enable auto import). > Compile! > > -Jake > ^^^ This worked for me. Th

Re: How to setup IntelliJ

2018-07-18 Thread Jacob Barrett
Checkout the latest from develop. Configure IntelliJ Build / Build Tools / Gradle / Uncheck "Create separate module per source set". Refresh the Gradle config (or enable auto import). Compile! -Jake

Re: How to setup IntelliJ

2018-07-18 Thread Jacob Barrett
This patch makes the editor work and breaks the compiler. ;) So it inverts the original problem that IJ compiles Test on Test dependencies but restricts them in the editor. The fix continues to be to write proper tests that don’t depend on other tests. I’ve started breaking out DUnit, which fix

Re: How to setup IntelliJ

2018-07-18 Thread Jinmei Liao
+1 for Dan's change. I cant stand IntelliJ showing me any red lines, even though compiler works. On Wed, Jul 18, 2018, 5:00 PM Dan Smith wrote: > I think there is an expectation that changes do not break the IDE as well. > Since this is a big enough pain for everyone, I think we need to do > som

Re: How to setup IntelliJ

2018-07-18 Thread Dan Smith
I think there is an expectation that changes do not break the IDE as well. Since this is a big enough pain for everyone, I think we need to do something that fixes this issue ASAP. Below is yet another hack that works around the issue, by telling intellij that everything is production source code

Re: How to setup IntelliJ

2018-07-18 Thread Jacob Barrett
To be clear this and editor issue not a compiler issue. Do not accidentally check any Gradle hacks in. To fix this someone needs to move framework code out of the test sources. > On Jul 18, 2018, at 3:08 PM, Jinmei Liao wrote: > > With Jake's merge, the my integration/distributed tests in geod

Re: How to setup IntelliJ

2018-07-18 Thread Jinmei Liao
With Jake's merge, the my integration/distributed tests in geode-cq (and maybe all other non-core modules) are not compiling nicely in IDEA. If you want a quick fix to your IDEA issue and not waiting till all the test refactors are done, you can add these lines in the beginning of that modules buil

Re: How to setup IntelliJ

2018-07-18 Thread Jacob Barrett
Even maven won’t fix the issue remain in IJ. We need to refactor the code so that Test code does not depend on Test code. It’s just bad form to do so. -Jake > On Jul 18, 2018, at 1:28 PM, Kirk Lund wrote: > > Sai had attempted to extract our testing framework(s) including DUnit to a > new geo

Re: How to setup IntelliJ

2018-07-18 Thread Kirk Lund
Sai had attempted to extract our testing framework(s) including DUnit to a new geode-test module. I thought it had been merged to develop but it seems to have been reverted. Anyone know why it had to be reverted? Other than moving to maven, another option would be to separate test types based on f

Re: How to setup IntelliJ

2018-07-18 Thread Jacob Barrett
The fix has been merged. It only fixes the compilation from IJ. The editor will continue to colorize dependencies from other test sources as missing. This can only be fixed by completing the extraction of the test framework sources into their own module. IJ editor assumes that test code should neve

Re: How to setup IntelliJ

2018-07-18 Thread Jacob Barrett
All, I have a fix that appears to address all these issue in a PR. I am just waiting for them to pass come CI because they effect the Gradle build too. Please don’t check in any “fixes” to this IJ integration issue. -Jake > On Jul 18, 2018, at 10:54 AM, Kirk Lund wrote: > > More details: If

Re: How to setup IntelliJ

2018-07-18 Thread Kirk Lund
More details: If I open up BasicDistributedTest, I can run it but all of the imports for classes that are also in distributedTest are RED and don't show up in the Project window. After pulling, the following commit is now my head revision. Unfortunately, it doesn't fix my problem. But it did cause

Re: How to setup IntelliJ

2018-07-18 Thread Kirk Lund
Yes, my head revision is... commit afc8dc8fca846d08581d8027f969ceadec911687 (*HEAD -> **develop*, *origin/develop*, *origin/HEAD*) Author: Anthony Baker Date: Mon Jul 16 16:56:03 2018 -0700 GEODE-5421 Updated dependencies Updated bundled library dependencies. The updated libaries

Re: How to setup IntelliJ

2018-07-18 Thread Anthony Baker
Are you using this commit? commit 89754953080cf3da9ce02a644bd3c0ac9afa1990 Author: Jacob Barrett Date: Tue Jul 17 17:03:22 2018 -0700 GEODE-5363: Fixes issue with build in IJ IDEA. - Splits up LuceneTestUtilities to removed duplication and compile fail. Anthony > On Jul 18, 201

How to setup IntelliJ

2018-07-18 Thread Kirk Lund
Does anyone have any instructions on setting up IntelliJ with the latest changes? I’ve tried new project from sources and I’ve tried using ./gradlew idea — neither works for me. Basically all non-unit tests end up not being a source set.