Re: Geode-9621: Spotless overstepping its boundary of formatter

2021-10-14 Thread Udo Kohlmeyer
!!!) The effort is much appreciated. --Udo From: Robert Houghton Date: Wednesday, October 13, 2021 at 8:07 AM To: dev@geode.apache.org Subject: Re: Geode-9621: Spotless overstepping its boundary of formatter I would not call it a “surge” of them, but I perceived an uptick in them. From: Udo

Re: Geode-9621: Spotless overstepping its boundary of formatter

2021-10-12 Thread Robert Houghton
I would not call it a “surge” of them, but I perceived an uptick in them. From: Udo Kohlmeyer Date: Tuesday, October 12, 2021 at 1:00 PM To: dev@geode.apache.org Subject: Re: Geode-9621: Spotless overstepping its boundary of formatter I had never explicitly asked this, but what was the main

Re: Geode-9621: Spotless overstepping its boundary of formatter

2021-10-12 Thread Udo Kohlmeyer
@geode.apache.org Subject: Re: Geode-9621: Spotless overstepping its boundary of formatter Again, Spotless is not changing code. That was a bad change, as you pointed out, and we modified Spotless to throw an exception instead of stripping out the version string indiscriminately. We surely could

Re: Geode-9621: Spotless overstepping its boundary of formatter

2021-10-12 Thread Robert Houghton
: dev@geode.apache.org Subject: Re: Geode-9621: Spotless overstepping its boundary of formatter Hi there Robert, Yes, you did work with me, but the solution to add my custom versions of jars that I want to test with, into the `DependencyConstraints` file just feels like the wrong approach. The

Re: Geode-9621: Spotless overstepping its boundary of formatter

2021-10-12 Thread Dan Smith
ose part of their changes as a result. -Dan From: Udo Kohlmeyer Sent: Monday, October 11, 2021 5:32 PM To: dev@geode.apache.org Subject: Re: Geode-9621: Spotless overstepping its boundary of formatter Hi there Robert, Yes, you did work with me, but the solutio

Re: Geode-9621: Spotless overstepping its boundary of formatter

2021-10-11 Thread Udo Kohlmeyer
’ configuration and leave every other configuration type (test, distributedTest, integrationTest, acceptanceTest, upgradeTest) alone. --Udo From: Robert Houghton Date: Tuesday, October 12, 2021 at 10:38 AM To: dev@geode.apache.org Subject: Re: Geode-9621: Spotless overstepping its boundary of

Re: Geode-9621: Spotless overstepping its boundary of formatter

2021-10-11 Thread Robert Houghton
Currently there is no way to exclude certain code blocks from the malicious code formatter. Therefore, my tests that require a specific hardcoded version of Spring to be used, will always either fail the validation or tests will fail due to spotless changing my testing scenario by affecting the

Geode-9621: Spotless overstepping its boundary of formatter

2021-10-11 Thread Udo Kohlmeyer
Hi there Geode Devs, Recently GEODE-9621 was introduced onto the develop branch. This new feature introduces a new bug where `spotlessApply` will remove all version dependencies out of gradle. I assume this is to combat the risin