+1 Udo. A very clear and descriptive spec; Nice work!
In short, these would be welcomed changes and would have very little impact
to *Spring Data for Apache Geode*, which nicely abstracts this API even
further using its POJO-based, Annotation configuration model for Function
Implementations as we
+1 for making the function service not static, and splitting servers from
clients.
Also +1 for Dan's suggestion.
On Wed, Mar 7, 2018 at 2:51 PM, Patrick Rhomberg
wrote:
> I did not know that! And then, yes, onRegion is much better.
>
> On Wed, Mar 7, 2018 at 2:43 PM, Dan Smith wrote:
>
> > >
I did not know that! And then, yes, onRegion is much better.
On Wed, Mar 7, 2018 at 2:43 PM, Dan Smith wrote:
> > If we're not opposed to descriptive verbosity, I might prefer
> "onServersHostingRegion" more than "onRegion".
>
> onRegion does not really mean "on the servers hosting region XXX".
> If we're not opposed to descriptive verbosity, I might prefer
"onServersHostingRegion" more than "onRegion".
onRegion does not really mean "on the servers hosting region XXX". It only
executes on a subset of the servers, potentially with retries, until it has
covered that entire dataset once. So
+1 for iteration towards better single responsibility design and more
easily-digestible classes.
Regarding method names, I think that there would be some good utility in
having "onGroup" methods, as well.
If we're not opposed to descriptive verbosity, I might prefer
"onServersHostingRegion" more t
I agree with Dan here. The C++ client took a stab at making
ExecutionService less static but didn't go this far. Rather than pull Cache
out of the either it is passed into each of the static factory methods,
wither as a Region, Pool or Cache itself. I like propose to add
Cache::getFunctionService t
Hi Udo,
+1 for making the function service not static and spitting it into client
and server FunctionService objects!
We do have Cache and ClientCache right now. So I would recommend this API
rather than putting two methods on Cache. Cache is already the the server
side API.
Cache {
ServerFunc
Hi there Apache Dev's,
Please look at the proposal to improve the FunctionService and remove
the static invocation of it from within the Cache.
https://cwiki.apache.org/confluence/display/GEODE/Function+Service+Refactor+-+Removal+of+static-ness+and+splitting+of+client+and+server-side+FunctionS
