Re: Fix for NPE during forceDisconnect candidate for 1.10.0

2019-08-13 Thread Juan José Ramos
+1 On Tue, Aug 13, 2019 at 6:03 PM Aaron Lindsey wrote: > +1 > > > On Aug 13, 2019, at 9:59 AM, Kirk Lund wrote: > > > > I guess we need at least one more vote to get this fix copied to the > 1.10.0 > > release branch. We just confirmed that this fix is NOT on that branch > yet. > > > > On Thu,

Re: Fix for NPE during forceDisconnect candidate for 1.10.0

2019-08-13 Thread Aaron Lindsey
+1 > On Aug 13, 2019, at 9:59 AM, Kirk Lund wrote: > > I guess we need at least one more vote to get this fix copied to the 1.10.0 > release branch. We just confirmed that this fix is NOT on that branch yet. > > On Thu, Aug 8, 2019 at 11:03 AM Juan José Ramos wrote: > >> +1 >> >> On Thu, Aug

Re: Fix for NPE during forceDisconnect candidate for 1.10.0

2019-08-13 Thread Kirk Lund
I guess we need at least one more vote to get this fix copied to the 1.10.0 release branch. We just confirmed that this fix is NOT on that branch yet. On Thu, Aug 8, 2019 at 11:03 AM Juan José Ramos wrote: > +1 > > On Thu, Aug 8, 2019 at 7:02 PM John Blum wrote: > > > +1 for Kirk's changes in 1

Re: Fix for NPE during forceDisconnect candidate for 1.10.0

2019-08-08 Thread Juan José Ramos
+1 On Thu, Aug 8, 2019 at 7:02 PM John Blum wrote: > +1 for Kirk's changes in 1.10. This will be critical for SD Neuman and > SBDG 1.3. > > On Thu, Aug 8, 2019 at 10:57 AM Owen Nichols wrote: > > > Hi Kirk and Mark, thank you for bringing your concern. > > > > Our “critical fixes” rule allows

Re: Fix for NPE during forceDisconnect candidate for 1.10.0

2019-08-08 Thread John Blum
+1 for Kirk's changes in 1.10. This will be critical for SD Neuman and SBDG 1.3. On Thu, Aug 8, 2019 at 10:57 AM Owen Nichols wrote: > Hi Kirk and Mark, thank you for bringing your concern. > > Our “critical fixes” rule allows critical fixes to be brought to the > release branch by proposal on

Re: Fix for NPE during forceDisconnect candidate for 1.10.0

2019-08-08 Thread Owen Nichols
Hi Kirk and Mark, thank you for bringing your concern. Our “critical fixes” rule allows critical fixes to be brought to the release branch by proposal on the dev list, as you have just done. If there is consensus from the Geode community that this NPE fix satisfies the “critical fixes” rule, D

Fix for NPE during forceDisconnect candidate for 1.10.0

2019-08-08 Thread Kirk Lund
I'd like to propose including the fix for GEODE-6959 in 1.10.0. Spring Boot users are very likely to hit this NPE during forceDisconnect. If a custom log4j2.xml is used without specifying the Geode AlertAppender, GMSMembershipManager may throw a NullPointerException when invoking AlertAppender.ge