> On Mar 17, 2020, at 9:03 AM, John Blum wrote:
>
> Additionally, it'd be ideal if the deprecated method were then adapted to
> delegate to the new approach. This will cut down on the number of required
> tests since then you only need a Unit Tests asserting the method performs
> the translat
Additionally, it'd be ideal if the deprecated method were then adapted to
delegate to the new approach. This will cut down on the number of required
tests since then you only need a Unit Tests asserting the method performs
the translation/delegating appropriately, unless of course the behavior is
I think we are also missing the other side of the coin.
Once we deprecate something and we now need a equivalent test that tests
the same behavior using the new method/approach. i.e now we have to
double up on the testing of said deprecated method/feature/class. First
we have to keep the tests
> On Mar 16, 2020, at 8:50 AM, Dan Smith wrote:
>
> +1
>
> One point though - we do need to leave some tests that specifically test
> the deprecated method(s), since we still support the deprecated APIs until
> we remove them. Everything else should be converted.
+1 for sure. Those tests wou
+1 on leaving testing of deprecated functionality in place
On Mon, Mar 16, 2020 at 11:50 AM Dan Smith wrote:
> +1
>
> One point though - we do need to leave some tests that specifically test
> the deprecated method(s), since we still support the deprecated APIs until
> we remove them. Everything
+1
One point though - we do need to leave some tests that specifically test
the deprecated method(s), since we still support the deprecated APIs until
we remove them. Everything else should be converted.
-Dan
On Sun, Mar 15, 2020 at 6:41 PM Jacob Barrett wrote:
> Hey Team,
>
> When deprecating
+1
I think we should make it a habit to convert all Geode code as part of the
pull request that introduces the deprecation so that this is not left as a
low priority item for some later point in time.
Something to look for when reviewing pull requests IMO.
On Sun, Mar 15, 2020 at 9:41 PM Jacob
Hey Team,
When deprecating a symbol, like class or method, please included a reference to
the replacement in the java docs. Also please include an example of converting
from the old API to the new. I am finding many many places in the source where
deprecated code has no hints at all. As many of
