Re: Deprecate SystemFailure Class

2019-10-30 Thread Bill Burcham
Hearing no objections or concerns, I will begin the deprecation process[1] for SystemFailure. After that I'll remove the dependencies [2] on SystemFailure in the membership subsystem. [1] https://issues.apache.org/jira/browse/GEODE-7369 [2] https://issues.apache.org/jira/browse/GEODE-7354

Re: Deprecate SystemFailure Class

2019-10-29 Thread Bill Burcham
The SystemFailure class is in the org.apache.geode package which means it is part of the public API. My purpose in messaging the dev list was to discover any concerns or objections to adding the deprecated flag to SystemFailure per GEODE-7369. Related to that work, I intend to eliminate calls to

Re: Deprecate SystemFailure Class

2019-10-29 Thread Bruce Schuchardt
Bill, are you proposing to remove calls to SystemFailure.initiateFailure() and remove all of the emergency-class stuff or just add a Deprecated flag to SystemFailure? On 10/28/19 12:01 PM, Bill Burcham wrote: The SystemFailure class is a clearing house for detecting and attempting to mitigate

Re: Deprecate SystemFailure Class

2019-10-29 Thread Joris Melchior
+1. On Mon, Oct 28, 2019 at 4:22 PM Robert Houghton wrote: > +1. > > On Mon, Oct 28, 2019 at 12:11 PM Bill Burcham > wrote: > > > The SystemFailure class is a clearing house for detecting and attempting > to > > mitigate SystemFailure exceptions e.g. VirtualMachineError and > > OutOfMemoryError

Re: Deprecate SystemFailure Class

2019-10-28 Thread Robert Houghton
+1. On Mon, Oct 28, 2019 at 12:11 PM Bill Burcham wrote: > The SystemFailure class is a clearing house for detecting and attempting to > mitigate SystemFailure exceptions e.g. VirtualMachineError and > OutOfMemoryError. > > This class should not exist. SystemFailure exceptions should be allowed

Deprecate SystemFailure Class

2019-10-28 Thread Bill Burcham
The SystemFailure class is a clearing house for detecting and attempting to mitigate SystemFailure exceptions e.g. VirtualMachineError and OutOfMemoryError. This class should not exist. SystemFailure exceptions should be allowed to percolate up and cause the JVM to terminate as soon as possible wi