Re: Dangers of using sockets in unit tests

2020-04-28 Thread Kirk Lund
The UpgradeTest job refuses to pass on PR #5011. As far I can tell, changing a few tests from UnitTest to IntegrationTest should NOT cause UpgradeTest to fail. It's the Tomcat Session upgrade tests and they just seem to fail every single time in this PR. Again, dunno what to do with this. Anyone fa

Re: Dangers of using sockets in unit tests

2020-04-27 Thread Kirk Lund
The problems in WindowsUnitTest jobs in CI are caused by various unit tests that are either bugged or should be moved to IntegrationTests. I found 3 tests named *IntegrationTests in src/test that need to move: * geode-core/src/test/java/org/apache/geode/distributed/internal/InternalDistributedSys

Re: Dangers of using sockets in unit tests

2020-04-27 Thread Kirk Lund
Yes, that's correct, SocketCreatorFactoryJUnitTest does not actually use any sockets. I assume some unit test that ran before it used sockets. What I really mean to say is: (1) singletons are bad, please let's keep working to get rid of them, (2) please be careful with unit tests -- I continue to o

Re: Dangers of using sockets in unit tests

2020-04-27 Thread Bruce Schuchardt
This seems more like it should be another call to remove all singletons. Tshe SocketCreatorFactoryJUnitTest that failed doesn't create a socket. It just configures a SocketCreator and then asserts that it was correctly configured. On 4/27/20, 1:58 PM, "Kirk Lund" wrote: This test starte

Dangers of using sockets in unit tests

2020-04-27 Thread Kirk Lund
This test started failing consistently on Windows (5 builds in a row so far!): org.apache.geode.internal.net.SocketCreatorFactoryJUnitTest > testNewSSLConfigSSLComponentLocator FAILED java.lang.AssertionError at org.junit.Assert.fail(Assert.java:86) at org.junit.Assert.assertTr