Bruce is correct that my refactored code is wrong.
I thought this method was called on the server but it is actually only
called on the client when the server pushes a message to the client through
the subscription queue.
So the current code is correct; just a bit hard to understand.
On Mon, Apr
+1
I think that code makes the method easier to understand but I don't
think the current message would be incorrect. The log message is only
issued if the server's setting doesn't match the client's setting, so
!clientCCEnabled is going to equal the serverCCEnabled that you've
introduced.
L
The first part of the condition "!this.concurrencyMessageIssued" is just
simply to make sure we only log this message once.
The second part "(tag != null) != this.concurrencyChecksEnabled" could be
changed to this:
boolean serverCCEnabled = this.concurrencyChecksEnabled;
boolean clientCCEnabled
I can't quite make out what the conditional is actually supposed to be
checking in the second half but it definitely looks wrong to me. Anyone
familiar with this method or what it's supposed to be doing?
private void concurrencyConfigurationCheck(VersionTag tag) {
// TODO: double negative in nex
