I didn't write this test, but I did rename it from Bug42226Test to
PersistentPartitionHangsDuringRestartRegressionTest and do some additional
cleaning to bring it up to minimal standards.
Please feel free to file a PR that removes all Jira and Trac ticket #s from
the codebase (or parts of it).
On
+1 We shouldn't even reference Apache JIRA tickets. References to
outside things like Trac tickets, JIRA tickets or even commit SHAs
become outdated over time.
On 2/20/19 11:28 AM, Alexander Murmann wrote:
I think it's important that we enable everyone in the community to be
equally successfu
I think it's important that we enable everyone in the community to be
equally successful and on top of that do NOT rely on non-Apache resources.
If we find value in Trac numbers, we should either find a way to make them
accessible to everyone or update the comment so that there is no value in
knowi
Well, the problem is that different people disagree on what's "meaningful"
in this context. For example:
See PersistentPartitionHangsDuringRestartRegressionTest.java
* /***
* * RegressionTest for bug 42226. *
* * 1. Member A has the bucket *
* * 2. Member B starts creating the bucket. It t
+1 - What Jake said.
> On Feb 19, 2019, at 5:21 PM, Jacob Barrett wrote:
>
> Comments that don’t provide meaningful context beyond what is already
> expressed in the code should be removed. A number to a system that the
> general public can’t access is not meaningful. Delete or replace with
Comments that don’t provide meaningful context beyond what is already expressed
in the code should be removed. A number to a system that the general public
can’t access is not meaningful. Delete or replace with meaningful comment.
-jake
> On Feb 19, 2019, at 1:41 PM, Michael Oleske wrote:
>
Hey Geode Dev Friends!
I was reviewing a PR (this one https://github.com/apache/geode/pull/3197)
and made a note that maybe we should remove comments that make references
to bug and trac numbers that people cannot reach (like me for one). Kirk
mentioned that some people (like him) have access to
