Re: Avoid PowerMockito

2021-03-10 Thread Donal Evans
@geode.apache.org Subject: Re: Avoid PowerMockito I've just submitted a PR to remove three uses of PowerMock.when that can be trivially replaced with Mockito.when: https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Fpull%2F6112&data=04%7C01%

Re: Avoid PowerMockito

2021-03-10 Thread Donal Evans
ike a very achievable task now. From: Kirk Lund Sent: Tuesday, March 9, 2021 12:13 PM To: dev@geode.apache.org Subject: Avoid PowerMockito I just reviewed a PR that was adding a unit test using PowerMockito. We've had lots of problems with PowerMockito leavin

Avoid PowerMockito

2021-03-09 Thread Kirk Lund
I just reviewed a PR that was adding a unit test using PowerMockito. We've had lots of problems with PowerMockito leaving the unit testing JVM corrupted for later tests. Using PowerMockito also discourages us from refactoring product code to have better design and be easier to unit test. So in prev