Re: Another change for 1.10.0 release

2019-08-08 Thread Owen Nichols
There appears to be consensus that this is a critical fix. The following commit has been brought into support/1.10.0 as the critical fix for GEODE-7055 : git cherry-pick -x 1438b56bf7ef44e758

Re: Another change for 1.10.0 release

2019-08-08 Thread Juan José Ramos
+1 On Thu, Aug 8, 2019 at 6:41 PM Ryan McMahon wrote: > +1 > > On Thu, Aug 8, 2019 at 10:40 AM John Blum wrote: > > > +1 for Dan's changes. > > > > On Thu, Aug 8, 2019 at 10:28 AM Owen Nichols > wrote: > > > > > Hi Dan, thank you for bringing your concern. > > > > > > Our “critical fixes” rule

Re: Another change for 1.10.0 release

2019-08-08 Thread Ryan McMahon
+1 On Thu, Aug 8, 2019 at 10:40 AM John Blum wrote: > +1 for Dan's changes. > > On Thu, Aug 8, 2019 at 10:28 AM Owen Nichols wrote: > > > Hi Dan, thank you for bringing your concern. > > > > Our “critical fixes” rule allows critical fixes to be brought to the > > release branch by proposal on t

Re: Another change for 1.10.0 release

2019-08-08 Thread John Blum
+1 for Dan's changes. On Thu, Aug 8, 2019 at 10:28 AM Owen Nichols wrote: > Hi Dan, thank you for bringing your concern. > > Our “critical fixes” rule allows critical fixes to be brought to the > release branch by proposal on the dev list [as you have just done]. If > there is consensus from th

Re: Another change for 1.10.0 release

2019-08-08 Thread Owen Nichols
Hi Dan, thank you for bringing your concern. Our “critical fixes” rule allows critical fixes to be brought to the release branch by proposal on the dev list [as you have just done]. If there is consensus from the Geode community that this GEODE-7055 fix satisfies the “critical fixes” rule, Dic

Another change for 1.10.0 release

2019-08-08 Thread Dan Smith
Hi all, I'd like to get the fix for GEODE-7055 (Don't send failure replies from a P2P reader thread) into the 1.10.0 release branch. This bug was causing a hang on startup for users of the session replication module that didn't put the session jars on the classpath of the locator. The hang doesn'