Re: API check error when adding a new method to a public interface

2021-11-23 Thread Dan Smith
led by internal code like the create gateway sender command, I think it would be better to add that method to the InternalGatewaySender interface. -Dan From: Owen Nichols Sent: Tuesday, November 23, 2021 10:42 AM To: dev@geode.apache.org Subject: Re: API check

Re: API check error when adding a new method to a public interface

2021-11-23 Thread Owen Nichols
Adding a new method to a public interface breaks anyone else implementing that interface, for example Spring. Adding a new method with a default implementation (except in the case where it is purely a composure of existing methods) isn't great either, you would probably have to throw Unsupporte

Re: API check error when adding a new method to a public interface

2021-11-23 Thread Alberto Gomez
Thanks, Anil. I will do as you suggest. Alberto From: Anilkumar Gingade Sent: Tuesday, November 23, 2021 7:33 PM To: dev@geode.apache.org Subject: Re: API check error when adding a new method to a public interface Alberto, I don’t think the intention is to

Re: API check error when adding a new method to a public interface

2021-11-23 Thread Anilkumar Gingade
Alberto, I don’t think the intention is to avoid, discourage adding a new method...As you have seen any changes to the API or adding a new API has implications on other parts of the product, it is good to validate/verify and address the dependency across the product and get everything working i

API check error when adding a new method to a public interface

2021-11-23 Thread Alberto Gomez
Hi, After the introduction of GEODE-9702 (https://issues.apache.org/jira/browse/GEODE-9702), adding a new method to a public interface will make the api-check-test-openjdk11 fail even if a default implementation is provided. My question is if the goal of this change is to forbid this type of c