Re: [PROPOSAL] Cherry pic GEODE-8331 to support branches

2020-07-22 Thread Dave Barnes
Please go ahead, Jinmei. Thanks for your contribution. On Wed, Jul 22, 2020 at 3:11 PM Dick Cavender wrote: > +1 > > -Original Message- > From: Anilkumar Gingade > Sent: Wednesday, July 22, 2020 2:44 PM > To: dev@geode.apache.org > Subject: Re: [PROPOSAL] Che

RE: [PROPOSAL] Cherry pic GEODE-8331 to support branches

2020-07-22 Thread Dick Cavender
+1 -Original Message- From: Anilkumar Gingade Sent: Wednesday, July 22, 2020 2:44 PM To: dev@geode.apache.org Subject: Re: [PROPOSAL] Cherry pic GEODE-8331 to support branches +1 This will provide a consistent experience our end user from 1.10 release version. On 7/22/20, 2:23 PM

Re: [PROPOSAL] Cherry pic GEODE-8331 to support branches

2020-07-22 Thread Anilkumar Gingade
+1 This will provide a consistent experience our end user from 1.10 release version. On 7/22/20, 2:23 PM, "Jinmei Liao" wrote: I would like to propose to cherry pick GEODE-8331: allow GFSH to connect to other versions of cluster (#5375) to support branches up to 1.10. This would allow g

Re: [PROPOSAL] Cherry pic GEODE-8331 to support branches

2020-07-22 Thread Owen Nichols
+🍒 I reviewed this fix and it looks good to me. The previous logic of locking gfsh to only work with the same minor version of the server needlessly makes upgrades a pain, and is unnecessary as most gfsh commands have not changed in recent releases, so only erroring when there is a real incomp

[PROPOSAL] Cherry pic GEODE-8331 to support branches

2020-07-22 Thread Jinmei Liao
I would like to propose to cherry pick GEODE-8331: allow GFSH to connect to other versions of cluster (#5375) to support branches up to 1.10. This would allow gfsh to connect to other versions of cluster and provide better error messages when command is not support by the connected cluster. Jin