Re: [PROPOSAL]: GEODE-7940 to support/1.12

2020-04-20 Thread Ju@N
Hello all, Thanks for the feedback. There seems to be enough consensus in that this is a critical fix, so I've cherry-picked the commit to the support/1.12 branch already (and updated the Fixed Versions field in JIRA). Best regards. On Mon, 20 Apr 2020 at 18:41, Owen Nichols wrote: > Weekend te

Re: [PROPOSAL]: GEODE-7940 to support/1.12

2020-04-20 Thread Owen Nichols
Weekend testing looks good to me +1 > On Apr 17, 2020, at 3:26 PM, Robert Houghton wrote: > > Conditional +1 from me too, pending a few days on develop with happy > results :) > > Thanks Juan! > > On Fri, Apr 17, 2020 at 1:41 AM Ju@N wrote: > >> Hello devs, >> >> I'd like to propose bringi

Re: [PROPOSAL]: GEODE-7940 to support/1.12

2020-04-17 Thread Robert Houghton
Conditional +1 from me too, pending a few days on develop with happy results :) Thanks Juan! On Fri, Apr 17, 2020 at 1:41 AM Ju@N wrote: > Hello devs, > > I'd like to propose bringing *GEODE-7940 [1]* to the *support/1.12* branch. > The bug is not new, seems quite old actually, but still seems

Re: [PROPOSAL]: GEODE-7940 to support/1.12

2020-04-17 Thread Udo Kohlmeyer
Agreed… this definitely meets the inclusion requirements. +1 On Apr 17, 2020, 1:50 AM -0700, Owen Nichols , wrote: Hi Juan, this looks like a great fix and definitely meets the “critical fix" standard. Also thanks for the detailed description. I noticed it was just merged to develop very recentl

Re: [PROPOSAL]: GEODE-7940 to support/1.12

2020-04-17 Thread Joris Melchior
Sounds like something we should include. +1 On Fri, Apr 17, 2020 at 4:41 AM Ju@N wrote: > Hello devs, > > I'd like to propose bringing *GEODE-7940 [1]* to the *support/1.12* branch. > The bug is not new, seems quite old actually, but still seems pretty > critical as it can lead to data loss in

Re: [PROPOSAL]: GEODE-7940 to support/1.12

2020-04-17 Thread Ju@N
Sounds good Owen, thanks!. On Fri, 17 Apr 2020 at 09:50, Owen Nichols wrote: > Hi Juan, this looks like a great fix and definitely meets the “critical > fix" standard. Also thanks for the detailed description. > > I noticed it was just merged to develop very recently. I would like to > see tha

Re: [PROPOSAL]: GEODE-7940 to support/1.12

2020-04-17 Thread Owen Nichols
Hi Juan, this looks like a great fix and definitely meets the “critical fix" standard. Also thanks for the detailed description. I noticed it was just merged to develop very recently. I would like to see that it gets through all tests and spends a couple days on develop, then I will be happy

[PROPOSAL]: GEODE-7940 to support/1.12

2020-04-17 Thread Ju@N
Hello devs, I'd like to propose bringing *GEODE-7940 [1]* to the *support/1.12* branch. The bug is not new, seems quite old actually, but still seems pretty critical as it can lead to data loss in WAN topologies. Long story short: when there are multiple parallel *gateway-senders* attached to the