Github user masaki-yamakawa commented on the issue:
https://github.com/apache/geode/pull/483
I don't mind even if you don't complete by early next week. I would
appreciate it if you can do it by the week after the next.
---
If your project is set up for it, you can reply to this emai
Github user bschuchardt commented on the issue:
https://github.com/apache/geode/pull/483
I will merge this pull request to develop. I may not get it done until
early next week.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user masaki-yamakawa commented on the issue:
https://github.com/apache/geode/pull/483
@kohlmu-pivotal Thank you for review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user masaki-yamakawa commented on the issue:
https://github.com/apache/geode/pull/483
I moved the test added to AutoConnectionSourceDUnitTest to
AutoConnectionSourceImplJUnitTest, and revert AutoConnectionSourceDUnitTest.
I tested by gradle precheckin.
---
If your project
Github user masaki-yamakawa commented on the issue:
https://github.com/apache/geode/pull/483
Thanks @bschuchardt for review. You are right, so delete the test added to
AutoConnectionSourceDUnitTest and add it to AutoConnectionSourceImplJUnitTest.
---
If your project is set up for it,
Github user masaki-yamakawa commented on the issue:
https://github.com/apache/geode/pull/483
Thanks @bschuchardt @kirklund for review.
Is this PR OK to merge?
If it is possible to merge, I do not have the merge permission, so I would
appreciate if you could please merge it.
-
Github user masaki-yamakawa commented on the issue:
https://github.com/apache/geode/pull/483
Thanks for the suggestion. I fixed that.
@bschuchardt @kirklund
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
