[GitHub] geode issue #450: GEODE-2632: create ClientCachePutBench

2017-07-20 Thread kirklund
Github user kirklund commented on the issue: https://github.com/apache/geode/pull/450 I'll wrap up this PR soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishe

[GitHub] geode issue #450: GEODE-2632: create ClientCachePutBench

2017-04-20 Thread upthewaterspout
Github user upthewaterspout commented on the issue: https://github.com/apache/geode/pull/450 Regarding putting JMH benchmarks in the core - seems fine. I think I originally made geode-benchmarks a separate project so it would be easy to share code and compare benchmarks between module

[GitHub] geode issue #450: GEODE-2632: create ClientCachePutBench

2017-04-20 Thread metatype
Github user metatype commented on the issue: https://github.com/apache/geode/pull/450 @upthewaterspout thoughts? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishe

[GitHub] geode issue #450: GEODE-2632: create ClientCachePutBench

2017-04-20 Thread kirklund
Github user kirklund commented on the issue: https://github.com/apache/geode/pull/450 @galen-pivotal I don't know enough about "DuplicatesStrategy.WARN" but it gets printed because JMH is pulling in all dependencies from all geode modules and the way we have our gradle build setup, th

[GitHub] geode issue #450: GEODE-2632: create ClientCachePutBench

2017-04-18 Thread galen-pivotal
Github user galen-pivotal commented on the issue: https://github.com/apache/geode/pull/450 Do you know why I get so many of these messages when I run the benchmark? ``` Encountered duplicate path "javassist/bytecode/annotation/ArrayMemberValue.class" during copy operation conf

[GitHub] geode issue #450: GEODE-2632: create ClientCachePutBench

2017-04-18 Thread galen-pivotal
Github user galen-pivotal commented on the issue: https://github.com/apache/geode/pull/450 This will set the same keys to the same values each iteration, because. I ran a benchmark last night with a benchmark that used only 99 values, but I didn't see a significant difference: ```

[GitHub] geode issue #450: GEODE-2632: create ClientCachePutBench

2017-04-13 Thread kirklund
Github user kirklund commented on the issue: https://github.com/apache/geode/pull/450 @davinash I'm using "$ ./gradlew geode-core:jmh" --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] geode issue #450: GEODE-2632: create ClientCachePutBench

2017-04-13 Thread davinash
Github user davinash commented on the issue: https://github.com/apache/geode/pull/450 +1. @kirklund what is correct way of running those benchmark. Is following command correct ./gradlew :geode-core:jmh --- If your project is set up for it, you can reply to this email and have y

[GitHub] geode issue #450: GEODE-2632: create ClientCachePutBench

2017-04-11 Thread kirklund
Github user kirklund commented on the issue: https://github.com/apache/geode/pull/450 Example results from running the benchmark (I think we'll want to reduce the time or # of iterations -- this is probably going to require some experimentation and comparing benchmarks as we write mor

[GitHub] geode issue #450: GEODE-2632: create ClientCachePutBench

2017-04-11 Thread kirklund
Github user kirklund commented on the issue: https://github.com/apache/geode/pull/450 Additional reviewers beyond those I tagged are also welcome! Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do