[GitHub] geode issue #426: GEODE-2660 Add @Experimental to the Redis adapter.

Github user bschuchardt commented on the issue: https://github.com/apache/geode/pull/426 got it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] geode issue #426: GEODE-2660 Add @Experimental to the Redis adapter.

Github user galen-pivotal commented on the issue: https://github.com/apache/geode/pull/426 @bschuchardt Check it out again; I force-pushed with just the annotation on GeodeRedisServer. --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] geode issue #426: GEODE-2660 Add @Experimental to the Redis adapter.

Github user bschuchardt commented on the issue: https://github.com/apache/geode/pull/426 my bad - I checkout out ggreen's branch by mistake. I don't see any @Experimental at all in your branch. It looks like your second commit removed it from GeodeRedisServer.java when you meant to

[GitHub] geode issue #426: GEODE-2660 Add @Experimental to the Redis adapter.

Github user galen-pivotal commented on the issue: https://github.com/apache/geode/pull/426 @bschuchardt This is just the experimental annotation, not changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] geode issue #426: GEODE-2660 Add @Experimental to the Redis adapter.

Github user bschuchardt commented on the issue: https://github.com/apache/geode/pull/426 Also, since we're talking about releasing v 1.2 soon it would be nice to add the Experimental annotation with this same commit since it is breaking compatibility with v 1.1. --- If your project

[GitHub] geode issue #426: GEODE-2660 Add @Experimental to the Redis adapter.

Github user bschuchardt commented on the issue: https://github.com/apache/geode/pull/426 I don't think we can merge these changes until the lock-service variables in ExeuctionHandlerContext are made static. As it's currently implemented every ExecutionContextHandler has its own lock

[GitHub] geode issue #426: GEODE-2660 Add @Experimental to the Redis adapter.

Github user galen-pivotal commented on the issue: https://github.com/apache/geode/pull/426 @bschuchardt want to merge this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] geode issue #426: GEODE-2660 Add @Experimental to the Redis adapter.

Github user upthewaterspout commented on the issue: https://github.com/apache/geode/pull/426 @galen-pivotal - it looks like the public API is just GeodeRedisServer. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] geode issue #426: GEODE-2660 Add @Experimental to the Redis adapter.

Github user galen-pivotal commented on the issue: https://github.com/apache/geode/pull/426 @upthewaterspout okay, you'd just put it on GeodeRedisServer? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] geode issue #426: GEODE-2660 Add @Experimental to the Redis adapter.

Github user upthewaterspout commented on the issue: https://github.com/apache/geode/pull/426 I think adding @Experimental the the internal classes might be overkill, @Experimental really just has meaning for the public API. --- If your project is set up for it, you can reply to this

[GitHub] geode issue #426: GEODE-2660 Add @Experimental to the Redis adapter.

Github user galen-pivotal commented on the issue: https://github.com/apache/geode/pull/426 I can't merge as I'm not a committer; would someone else be so kind, assuming these changes look good? --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] geode issue #426: GEODE-2660 Add @Experimental to the Redis adapter.

Github user galen-pivotal commented on the issue: https://github.com/apache/geode/pull/426 @hiteshk25 @kirklund @upthewaterspout @bschuchardt --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have