[GitHub] geode issue #367: GEODE-2370: First pass at a CONTRIBUTING document.

2017-01-30 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on the issue: https://github.com/apache/geode/pull/367 Merged, please close. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wi

[GitHub] geode issue #367: GEODE-2370: First pass at a CONTRIBUTING document.

2017-01-30 Thread echobravopapa
Github user echobravopapa commented on the issue: https://github.com/apache/geode/pull/367 The latest doc in PR has instructions on running a single ctest... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] geode issue #367: GEODE-2370: First pass at a CONTRIBUTING document.

2017-01-29 Thread davinash
Github user davinash commented on the issue: https://github.com/apache/geode/pull/367 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] geode issue #367: GEODE-2370: First pass at a CONTRIBUTING document.

2017-01-28 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on the issue: https://github.com/apache/geode/pull/367 We should include links to CTest documents. To run singles or subsets of tests you need to use ctest directly. ctest -R --- If your project is set up for it, you can

[GitHub] geode issue #367: GEODE-2370: First pass at a CONTRIBUTING document.

2017-01-27 Thread davinash
Github user davinash commented on the issue: https://github.com/apache/geode/pull/367 LGTM one question since I am new to CMAKE, how can we run single test ? And should we include instructions for a the same --- If your project is set up for it, you can reply to this email and ha

[GitHub] geode issue #367: GEODE-2370: First pass at a CONTRIBUTING document.

2017-01-27 Thread echobravopapa
Github user echobravopapa commented on the issue: https://github.com/apache/geode/pull/367 @davinash sounds like a good idea I'll have updated document today --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] geode issue #367: GEODE-2370: First pass at a CONTRIBUTING document.

2017-01-27 Thread davinash
Github user davinash commented on the issue: https://github.com/apache/geode/pull/367 IMO we also should add command on how to run integration run. I could run integration tests using following command. `cmake --build . --target run-integration-tests` --- If your project is se