Github user davinash commented on the issue:
https://github.com/apache/geode/pull/344
@pivotal-jbarrett @metatype I have merged the change.
https://git-wip-us.apache.org/repos/asf?p=geode.git;h=e92cb63
Closing this PR now.
---
If your project is set up for it, you can re
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/344
@metatype looks good if you want to merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user metatype commented on the issue:
https://github.com/apache/geode/pull/344
Any further discussion?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes s
Github user davinash commented on the issue:
https://github.com/apache/geode/pull/344
Thanks @pivotal-jbarrett , I have handled review comments, tested on Ubuntu
and CentOS.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/344
Looking at this a little more... I don't think that gfppcache directly
depends on -lz. If it is just a transitive dependency from libxml2 then we
should move the -lz to target library definit
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode/pull/344
This PR fixed the issue for me on ubuntu.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user davinash commented on the issue:
https://github.com/apache/geode/pull/344
@pivotal-jbarrett Yes you are correct, previous change will break windows.
I have updated PR. Tested on ubuntu and CentOS.
---
If your project is set up for it, you can reply to this email and have
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode/pull/344
I've been down this ordering road before. Pretty sure this change will
break on Windows and possibly Solaris. If the known to work platforms in the
BUILDING doc, which have you tested this pu
Github user PivotalSarge commented on the issue:
https://github.com/apache/geode/pull/344
Elegant. Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and w
