[GitHub] geode-native pull request #28: Feature/geode 2440

2017-02-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode-native/pull/28 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode-native pull request #28: Feature/geode 2440

2017-02-23 Thread echobravopapa
Github user echobravopapa commented on a diff in the pull request: https://github.com/apache/geode-native/pull/28#discussion_r102809166 --- Diff: src/cppcache/integration-test/testThinClientFixedPartitionResolver.cpp --- @@ -236,8 +236,8 @@ DUNIT_TASK_DEFINITION(CLIENT1, CheckPrSi

[GitHub] geode-native pull request #28: Feature/geode 2440

2017-02-23 Thread mmartell
Github user mmartell commented on a diff in the pull request: https://github.com/apache/geode-native/pull/28#discussion_r102771536 --- Diff: src/cppcache/src/ClientMetadata.cpp --- @@ -344,7 +344,7 @@ int ClientMetadata::assignFixedBucketId(const char* partitionName, FixedMa

[GitHub] geode-native pull request #28: Feature/geode 2440

2017-02-23 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/28#discussion_r102749040 --- Diff: src/cppcache/src/ClientMetadata.cpp --- @@ -344,7 +344,7 @@ int ClientMetadata::assignFixedBucketId(const char* partitionName,

[GitHub] geode-native pull request #28: Feature/geode 2440

2017-02-22 Thread mmartell
GitHub user mmartell opened a pull request: https://github.com/apache/geode-native/pull/28 Feature/geode 2440 Convert hashcode from unsigned to signed and remove static_casts that are no longer necessary. You can merge this pull request into a Git repository by running: $ git