Re: [DISCUSS] Requiring final keyword on every parameter and local variable

2021-04-15 Thread Kirk Lund
PS: Here is my version of that constructor after refactoring the class: PartitionedRegionClearMessage(Set recipients, PartitionedRegion region, ReplyProcessor21 processor, PartitionedRegionClearMessage.OperationType operationType, RegionEventImpl event) { super(recipients, region.getPRId

Re: [DISCUSS] Requiring final keyword on every parameter and local variable

2021-04-15 Thread Kirk Lund
Here's a quote about code reviews in Clean Code in Python: We should invest time in code reviews, thinking about what is good code, > and how readable and understandable it is. When looking at the code written > by a peer, you should ask such questions as: > * Is this code easy to understand and f

[DISCUSS] Requiring final keyword on every parameter and local variable

2021-04-15 Thread Kirk Lund
Moving the discussion to this thread. Sorry for starting off with a VOTE. I'm primarily interested in Maintainability https://en.wikipedia.org/wiki/Software_quality#Maintainability, and my concern regarding using "final" on method parameters or local variables is about Code Readability: understand