Seems like there is enough consensus. I will go ahead and create the repo.
Thanks!
-Dan
On Fri, Nov 16, 2018 at 1:37 PM Kirk Lund wrote:
> +1 total agreement then!
>
> On Fri, Nov 16, 2018 at 10:05 AM Dan Smith wrote:
>
> > Hi Kirk,
> >
> > What we're thinking of putting in geode-benchmarks ar
+1 total agreement then!
On Fri, Nov 16, 2018 at 10:05 AM Dan Smith wrote:
> Hi Kirk,
>
> What we're thinking of putting in geode-benchmarks are new, multi host
> benchmarks of the full system with the public APIs, not microbenchmarks. We
> weren't planning on doing anything with the JMH benchma
+1 to Dan’s proposal - just makes sense
> On Nov 16, 2018, at 10:05 AM, Dan Smith wrote:
>
> Hi Kirk,
>
> What we're thinking of putting in geode-benchmarks are new, multi host
> benchmarks of the full system with the public APIs, not microbenchmarks. We
> weren't planning on doing anything wit
Hi Kirk,
What we're thinking of putting in geode-benchmarks are new, multi host
benchmarks of the full system with the public APIs, not microbenchmarks. We
weren't planning on doing anything with the JMH benchmarks at the moment. I
agree with you those should stay in the geode module they are test
That makes sense for some benchmarks but not others. For example, while
working on the Logging changes, I wrote a some benchmarks that directly use
some new internal code to ensure that the new changes perform well.
+1 to creating a benchmarks repo that has general perf tests that will be
run in t
+1
On Thu, Nov 15, 2018 at 8:22 PM Udo Kohlmeyer wrote:
> +1, never thought there was any other option...
>
>
> On 11/15/18 10:47, Dan Smith wrote:
> > Hi all,
> >
> > We (Naba, Sean, Brian and I) would like to add some benchmarks for geode,
> > with a goal of eventually running them as part of
+1, never thought there was any other option...
On 11/15/18 10:47, Dan Smith wrote:
Hi all,
We (Naba, Sean, Brian and I) would like to add some benchmarks for geode,
with a goal of eventually running them as part of our concourse build and
detecting performance changes.
We think it makes sens
+1 I think a separate repo makes sense, and I'm excited for this effort!
On Thu, Nov 15, 2018 at 10:47 AM Dan Smith wrote:
> Hi all,
>
> We (Naba, Sean, Brian and I) would like to add some benchmarks for geode,
> with a goal of eventually running them as part of our concourse build and
> detect
Hi all,
We (Naba, Sean, Brian and I) would like to add some benchmarks for geode,
with a goal of eventually running them as part of our concourse build and
detecting performance changes.
We think it makes sense to put these benchmarks in a separate
geode-benchmarks repository. That will make them
