Re: [VOTE] Move geode to the attic

2022-10-30 Thread Xiaojian Zhou
Vote to move to attic. Regards Xiaojian Zhou, PMC of geode From: Dan Smith Date: Friday, October 28, 2022 at 3:15 PM To: u...@geode.apache.org , dev@geode.apache.org Subject: Re: [VOTE] Move geode to the attic There is still an ongoing discussion on the private@geode list, let's go ahead

Re: [VOTE] Apache Geode 1.13.3.RC1

2021-06-22 Thread Xiaojian Zhou
+1 On 6/21/21, 2:23 PM, "Nabarun Nag" wrote: +1 based on the following: * build from source * running gfsh * starting 2 site WAN cluster * verifying data propagation from the 2 sites using puts and gets * Rolling clusters from 1.12 to the release can

Re: [PROPOSAL] backport GEODE-8998 to 1.14

2021-03-04 Thread Xiaojian Zhou
+1 On 3/4/21, 9:37 AM, "Darrel Schneider" wrote: I'm resending this request because my previous request was labelled as junk. I would like to backport GEODE-8998 to 1.14. If fixes an NPE that will cause the geode cluster to not be able to do any cluster messaging if thread moni

Re: [Suspected Spam] [PROPOSAL] backport GEODE-8998 to 1.14

2021-03-04 Thread Xiaojian Zhou
+1 On 3/4/21, 9:31 AM, "Mark Hanson" wrote: +1 On 3/3/21, 5:18 PM, "Darrel Schneider" wrote: I would like to backport GEODE-8998 to 1.14. If fixes an NPE that will cause the geode cluster to not be able to do any cluster messaging if thread monitoring is disab

Re: [Proposal] Backport GEODE-8958 into 1.14.x, 1.13.x, 1.12.x branches

2021-03-03 Thread Xiaojian Zhou
+1 On 3/1/21, 11:30 PM, "Owen Nichols" wrote: That sounds a lot better than never expiring them if that does happen, I think this would be good to include. On 3/1/21, 2:41 PM, "Mark Hanson" wrote: I would like to backport GEODE-8958 into previous release branches to allevia

Re: [DISCUSS] Geode 1.14

2021-01-04 Thread Xiaojian Zhou
My opinion: (1) List out must fix bugs for 1.4 (I don’t think there’s any, but it’s good to review) (2) cut the 1.4 release branch and start the stabilization period asap. Gester From: Anilkumar Gingade Date: Monday, January 4, 2021 at 7:23 AM To: dev@geode.apache.org Subject: Re: [DISCUSS] Ge

[PROPOSAL] backporting GEODE-8764 to 1.13 and 9.10

2020-12-03 Thread Xiaojian Zhou
GEODE-8764 is an enhanced version of GEODE-6930. Lucene functions should only require DATA:READ permission on the specified region, no need to gain permission on other unrelated regions. The fix has no risk. Regards Xiaojian Zhou

Re: [PROPOSAL] Change the default value of conserve-sockets to false

2020-12-02 Thread Xiaojian Zhou
OK, I double checked, my memory is wrong. It was true as early as 6.0. From: Xiaojian Zhou Date: Wednesday, December 2, 2020 at 3:29 PM To: dev@geode.apache.org Subject: Re: [PROPOSAL] Change the default value of conserve-sockets to false +1 I think it’s good to change back the default to be

Re: [PROPOSAL] Change the default value of conserve-sockets to false

2020-12-02 Thread Xiaojian Zhou
+1 I think it’s good to change back the default to be false. It was false before. From: Barrett Oglesby Date: Wednesday, December 2, 2020 at 3:14 PM To: dev@geode.apache.org Subject: Re: [PROPOSAL] Change the default value of conserve-sockets to false I ran a bunch of tests using the long-runnin

Re: Geode - store and query JSON documents

2020-11-26 Thread Xiaojian Zhou
= new HashSet<>(); while (results.hasNext()) { results.next().stream() .forEach(struct -> { Object value = struct.getValue(); if (value instanceof PdxInstance) { PdxInstance pdx = (PdxInstance) value;

Re: Geode - store and query JSON documents

2020-11-23 Thread Xiaojian Zhou
share the sample query/code fetching this data . Thanks Ankit. On Mon, 23 Nov 2020 at 22:43, Xiaojian Zhou wrote: > Anil: > > The syntax is OQL. But I understand they want to query JSON object base on > the criteria. > > On 11/23/20, 9:08 AM

Re: [PROPOSAL] Change the default value of conserve-sockets to false

2020-11-23 Thread Xiaojian Zhou
Passed dunit tests is not enough. It might only mean we don't have enough test coverage. We need to inspect the code to see what will be the behavior when 2 servers configured different conserve-sockets. On 11/20/20, 3:30 PM, "Donal Evans" wrote: Regarding behaviour during RollingUpgrad

Re: Geode - store and query JSON documents

2020-11-23 Thread Xiaojian Zhou
However in above document, it did not provided a query example on JSON object. I can give you some sample code to query on JSON. Regards Xiaojian Zhou On 11/22/20, 11:53 AM, "ankit Soni" wrote: Hello geode-devs, please prov

Re: Geode - store and query JSON documents

2020-11-23 Thread Xiaojian Zhou
. Regards Xiaojian Zhou On 11/22/20, 11:53 AM, "ankit Soni" wrote: Hello geode-devs, please provide a guidance on this. Ankit. On Sat, 21 Nov 2020 at 10:23, ankit Soni wrote: > Hello team, > > I am *evaluating usage of Geode (1.12) with storing

Re: [DISCUSS] Adding CODEOWNERS to Apache Geode

2020-11-20 Thread Xiaojian Zhou
+1 I saw the template of splitting the geode code. Can someone nominate a few codeowners in the file as examples? On 11/20/20, 7:32 AM, "Alexander Murmann" wrote: +1 I agree with Owen's point that this will improve the experience for new contributors. It also helps people new to th

Re: [PROPOSAL] Change the default value of conserve-sockets to false

2020-11-20 Thread Xiaojian Zhou
1) Conserve-socket will only impact p2p connection. If set to false, that mean the p2p connections between 2 servers can be created on request, as many as needed. 2) currently the default setting is true (I don't remember when did we change it from false to true) 3) For rollingUpgrade, unfortun

Re: [VOTE] Apache Geode 1.13.1.RC2

2020-11-20 Thread Xiaojian Zhou
+1 On 11/17/20, 12:52 PM, "Dave Barnes" wrote: +1 Docs review - Built user guides for geode and geode-native using the provided Docker scripts. - Opened the pre-built Geode javadocs in the binary distro. Everything worked and looked as it should. NOTE:

Re: Apache Geode 1.13.1 patch proposal

2020-11-12 Thread Xiaojian Zhou
+1 On 11/12/20, 11:54 AM, "Anilkumar Gingade" wrote: +1 On 11/12/20, 11:34 AM, "Owen Nichols" wrote: +1 Sounds good to me, thanks @Dick for stepping up! Let's also start posting Geode release artifacts to GitHub too (as many other projects already do). I've backfil

[PROPOSAL] backport GEODE-8651 to 1.13, 9.10, 9.9

2020-10-27 Thread Xiaojian Zhou
problem exists in earlier versions and should be backported. Regards Xiaojian Zhou

[PROPOSAL] Backport GEODE-8608 to support 1.13, 1.12 branch

2020-10-14 Thread Xiaojian Zhou
Hi, There’s a race that StateFlush could hang when the target member is shutdown. GEODE-8608 fixed. This fix is a patch to GEODE-8385. The fix should be backported to all previous versions with GEODE-8385. We are still waiting for prechecking to finish. Regards Xiaojian Zhou

[PROPOSAL] Backport GEODE-6008 to support 1.12

2020-09-29 Thread Xiaojian Zhou
. Regards Xiaojian Zhou

[PROPOSAL] Backport GEODE-8475 to 1.13

2020-09-02 Thread Xiaojian Zhou
Hi, All: I want to backport my fix in GEODE-8475 to 1.13. It fixed a hang caused by a potential deadlock. This fix is quite safe, I have verified it by running all queue related regression. Regards Gester

Re: [PROPOSAL] Backport GEODE-8432 to 1.13

2020-08-20 Thread Xiaojian Zhou
It's using region path instead of getting the region. It should be no risk. On 8/19/20, 10:25 AM, "Xiaojian Zhou" wrote: This problem also exists in 1.13.

[PROPOSAL] Backport GEODE-8432 to 1.13

2020-08-19 Thread Xiaojian Zhou
This problem also exists in 1.13.

Re: [VOTE] change Default branch for geode-examples to 'develop'

2020-07-31 Thread Xiaojian Zhou
-1 I often need to build geode-examples on older geode version (more frequent than current version). One more irrelevant comments: we do need to enhance our geode-examples. The current examples are too weak. On 7/30/20, 8:16 AM, "Blake Bender" wrote: FWIW, Geode Native works around th

Re: [PROPOSAL] port GEODE-8385 changes to support/1.13

2020-07-31 Thread Xiaojian Zhou
+1 On 7/29/20, 2:03 PM, "Bruce Schuchardt" wrote: This has been merged to support/1.13. Thank you all On 7/29/20, 12:47 PM, "Owen Nichols" wrote: +1 On 7/29/20, 9:56 AM, "Dave Barnes" wrote: +1 Thanks, Bruce. On Wed, Jul 29, 20

Re: [PROPOSAL] Postpone Geode 1.14

2020-07-30 Thread Xiaojian Zhou
+1 On 7/29/20, 1:35 PM, "Mark Bretl" wrote: +1 Should we need to drop a line to user@geode or is communicating on this list enough once decided? --Mark On Wed, Jul 29, 2020 at 7:05 AM Joris Melchior wrote: > +1 > > On 2020-07-28, 7:34 PM, "Alexander Murmann"

Re: [DISCUSS] RFC - Avoid the queueing of dropped events by the primary gateway sender when the gateway sender is stopped

2020-07-10 Thread Xiaojian Zhou
. I will try to find a light-weight solution with minimum impact to current code. Regards Xiaojian Zhou On 7/8/20, 1:05 PM, "Eric Shu" wrote: I think the only case the memory issue occurred is when all gateway senders are stopped in the wan-site. Otherwise another member would

[PROPOSAL] merge GEODE-8259 to support branches

2020-06-30 Thread Xiaojian Zhou
low risk. So it would be nice to bring to before 1.13.0 release. Regards Xiaojian Zhou

PROPOSAL to bring GEODE-8259 to support branches

2020-06-30 Thread Xiaojian Zhou
low risk. So it would be nice to bring before 1.13.0 release. Regards Xiaojian Zhou

[PROPOSAL] merge GEODE-8259 to support branches

2020-06-30 Thread Xiaojian Zhou
risk. So it would be nice to bring to before 1.13.0 release. Regards Xiaojian Zhou

Re: [PROPOSAL] Add windows jobs to PR checks

2020-06-26 Thread Xiaojian Zhou
g system like above "regression" script. On 6/25/20, 4:09 PM, "Xiaojian Zhou" wrote: I vote to is also with current/existing process (not running for every PR). We can create an on-request prechecking running on windows machine like what we did for running some re

Re: [PROPOSAL] Add windows jobs to PR checks

2020-06-25 Thread Xiaojian Zhou
I vote to is also with current/existing process (not running for every PR). We can create an on-request prechecking running on windows machine like what we did for running some regression tests, if someone really need to run it on windows (Actually, I'd love to have this tool) On 6/25/20, 1:52

Re: [DISCUSSION] Stop using the Geode Repository for Feature/WIP Branches

2020-06-03 Thread Xiaojian Zhou
We have discussed that when in Common team. The current solution worked perfectly. One person will merge the develop into feature/GEODE-7665 (which conceptually can be anyone. I did 2 times) every week. Now Naba is taking the responsibility to do the weekly merge. He did great! Fork will caus

Re: [PROPOSAL] include GEODE-8073 in Geode 1.13 support branch

2020-05-06 Thread Xiaojian Zhou
+1 This bug reproduced again in today's regression. It's better to backport to 1.13. On Wed, May 6, 2020 at 11:42 AM Jinmei Liao wrote: > +1 > > On Wed, May 6, 2020 at 11:40 AM Owen Nichols wrote: > > > +1 to fix this NPE on support/1.13 and also support/1.12 > > > > > On May 6, 2020, at 11:19

Re: Creation of buckets for partitioned region

2020-02-14 Thread Xiaojian Zhou
But these servers will be assigned buckets later by rebalance. On Fri, Feb 14, 2020 at 9:25 AM Barry Oglesby wrote: > Mario, > > Yes, a query execution causes the buckets to be created. > > Also, onRegion function execution causes them to be created as well. > > There is an API to create the buc

Re: RFC - Logging to Standard Out

2020-01-08 Thread Xiaojian Zhou
+1 On Wed, Jan 8, 2020 at 1:56 PM Jason Huynh wrote: > +1 > > On Wed, Jan 8, 2020 at 1:21 PM Dan Smith wrote: > > > +1. Looks good! > > > > -Dan > > > > On Wed, Jan 8, 2020 at 12:56 PM Blake Bender wrote: > > > > > +1 - this is also a todo item for the native client, I think. NC has a > > bug

RFC is about to finish collecting feedback: Support for clear operation on partitioned region

2019-12-31 Thread Xiaojian Zhou
ed the RFC accordingly and answered all the questions. The period of collecting feedback will finish by the end of this week. Should you have questions and concerns, please add to the RFC within this week. Thank you. Regards Xiaojian Zhou (Gester)

[DISCUSS] Support for clear operation on partitioned region

2019-12-18 Thread Xiaojian Zhou
support clear on Distributed Region. But most of the customers are using Partitioned Region nowadays. Please put your comments in RFC directly instead of on the email thread. Thank you. Regards Xiaojian Zhou (Gester)

Re: defunct branches

2019-11-27 Thread Xiaojian Zhou
Yes, I cannot find GEODE-3967 either. %103 ~/git12/geode > git br -r | grep 3967 %103 ~/git12/geode > On Thu, Apr 18, 2019 at 9:28 AM Patrick Rhomberg wrote: > To elaborate on what Dan said: > > What has happened is that your local record of the remote references has > 400+ remote branch refer

Re: [DISCUSS/VOTE] Proposal to bring GEODE-7465 to release/1.11.0

2019-11-26 Thread Xiaojian Zhou
+1 On Tue, Nov 26, 2019 at 12:48 PM Joris Melchior wrote: > +1 > > On Tue, Nov 26, 2019 at 2:41 PM Jason Huynh wrote: > > > +1 > > > > On Tue, Nov 26, 2019 at 11:34 AM Anilkumar Gingade > > wrote: > > > > > +1 > > > > > > On Tue, Nov 26, 2019 at 11:32 AM Udo Kohlmeyer wrote: > > > > > > > Thi

Re: WAN Get-Initial-Image

2019-11-25 Thread Xiaojian Zhou
DId you run "create async-event-queue"? On Mon, Nov 25, 2019 at 9:23 AM anjana_nair wrote: > Hi, > > We are trying to solve cloud replication using > asyncEventListeners.However > the sample AsyncEventListener is not getting fired when I try a put. Could > you please look into this. Commands t

Re: Odg: gateway sender queue

2019-11-14 Thread Xiaojian Zhou
The --cleanQueue option is a similar idea as Barry's "DeadLetter" spike. I remembered that we decided not to do it. On Wed, Nov 13, 2019 at 11:41 PM Mario Ivanac wrote: > Hi, > > just to remind you on last question: > > what is your opinion on adding additional option in gfsh command "start >

Re: Lucene upgrade

2019-11-07 Thread Xiaojian Zhou
2 isn't valid and it's > definitely the least amount of work to do, I still vote option 1. > > On Wed, Nov 6, 2019 at 5:16 PM Xiaojian Zhou wrote: > > > Usually re-creating region and index are expensive and customers are > > reluctant to do it, according to my

Re: Lucene upgrade

2019-11-06 Thread Xiaojian Zhou
Usually re-creating region and index are expensive and customers are reluctant to do it, according to my memory. We do have an offline reindex scripts or steps (written by Barry?). If that could be an option, they can try that offline tool. I saw from Mario's email, he said: "I didn't found a way

Re: Lucene upgrade

2019-11-06 Thread Xiaojian Zhou
He tried to upgrade lucene version from current 6.6.4 to 8.2. There're some challenges. One challenge is the codec changed, which caused the format of index is also changed. That's why we did not implement it. If he resolved the coding challenges, then rolling upgrade will probably need option-2

Re: [vote/discuss]Override stressNewTest for Pull Request #4250?

2019-10-31 Thread Xiaojian Zhou
It finished after 4 hour 51 minutes. It looks like we do need to increase the timeout for stressNewTest. On Thu, Oct 31, 2019 at 4:45 PM Darrel Schneider wrote: > +1 > > On Thu, Oct 31, 2019 at 4:16 PM Jinmei Liao wrote: > > > +1 > > > > On Thu, Oct 31, 2019

Re: [vote/discuss]Override stressNewTest for Pull Request #4250?

2019-10-31 Thread Xiaojian Zhou
I'm curious to see the new stressNew test result too. On Thu, Oct 31, 2019 at 3:26 PM Owen Nichols wrote: > I’ve retriggered StressNew < > https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-pr/jobs/StressNewTestOpenJDK11/builds/4758> > with a temporarily-increased timeout

Re: [DISCUSS] log4j errors/warnings

2019-10-22 Thread Xiaojian Zhou
rather than simply throwing in another dependency, testRuntime or > otherwise. It is too easy for that to be inadvertently and incorrectly > changed by some maintainer later on. > > $0.02 > > -j > > > [1] > > https://github.com/spring-projects/spring-boot-data-geode/

Re: [DISCUSS] log4j errors/warnings

2019-10-22 Thread Xiaojian Zhou
I hit this problem in PR. I am just curious why it did not happen before? On Tue, Oct 22, 2019 at 9:44 AM Kirk Lund wrote: > I'm ok with adding log4j-core to the testRuntime for all unit test targets > to prevent the ERROR message. Any other input? > > On Fri, Oct 18, 2019 at 3:10 PM John Blum

VOTE: I need to add onto auth list for apachegeode-ci.info

2019-10-08 Thread Xiaojian Zhou
I cannot login now for some reason. I need your vote to turn on the permissions. Regards Xiaojian Zhou

Re: [VOTE] Adding a lucene specific fix to release/1.10.0

2019-09-19 Thread Xiaojian Zhou
ts. - How “sensitive” is the area of code it touches? Not sensitive. - What new tests have been added? New dunit tests and junit tests. Regards Gester On Thu, Sep 19, 2019 at 11:21 AM Owen Nichols wrote: > > On Sep 19, 2019, at 11:15 AM, Xiaojian Zhou wrote: > > > > Owen:

Re: [VOTE] Adding a lucene specific fix to release/1.10.0

2019-09-19 Thread Xiaojian Zhou
AM Eric Shu wrote: > > > >> +1 > >> > >> > >> On Thu, Sep 19, 2019 at 10:59 AM Benjamin Ross > wrote: > >> > >>> +1 > >>> > >>> On Thu, Sep 19, 2019 at 10:50 AM Nabarun Nag wrote: > >>> > >>>>

[VOTE] Adding a lucene specific fix to release/1.10.0

2019-09-19 Thread Xiaojian Zhou
I want to merge GEODE-7208, which is lucene specific fix The fix will enable indexing on inherited attributes in user object. revision 4ec87419d456748a7d853e979c90ad4e301b2405 Regards Gester

Re: [VOTE] Adding new AEQ feature to release/1.10.0

2019-09-13 Thread Xiaojian Zhou
+1 On Fri, Sep 13, 2019 at 3:23 PM Nabarun Nag wrote: > Hi Geode Community , > > [GEODE-7121] > > I would like to include the new feature of creating AEQs with a paused > event processor to the release 1.10 branch. This also includes the feature > to resume the AEQ at a later point in time. > Th

Re: [DISCUSS] require reviews before merging a PR

2019-05-31 Thread Xiaojian Zhou
I think my recent practice with Eric Shu's PR #3623 could be a good example. In this specific bug with a lot of context, it's hard for Eric Shu to find 3 persons to review. Bruce and I are the 2 right persons who know the history and context. Eric came to me many times and we had a lot of discuss

Re: [DISCUSS] Propose new committer and PMC member - Peter Tran

2019-05-20 Thread Xiaojian Zhou
+1 On Mon, May 20, 2019 at 11:50 AM Mike Stolz wrote: > This has the heading [DISCUSS] instead of [VOTE] > > I'm +1 anyway. > > On Mon, May 20, 2019 at 2:15 PM Jinmei Liao wrote: > > > I'd like to discuss the proposal to add Peter Tran as a new Geode > > committer and PMC member. Peter has been

Re: Very red CI -> Hold merges, please

2019-02-07 Thread Xiaojian Zhou
WANRollingUpgradeNewSenderProcessOldEvent is not related with GEODE-3967. I wonder why search guided us to GEODE-3967. Regards Gester On Thu, Feb 7, 2019 at 8:34 PM Owen Nichols wrote: > Pipeline is back to green now. Thank you to everyone who stepped up to > get things back on track. > > If y

Re: 2 minute gateway startup time due to GEODE-5591

2018-09-05 Thread Xiaojian Zhou
OK, after discussion with Jason and Ryan. a PR #2425 is ready. It contains fix for 3 issues, including skipping the 2-minute-timeout. On Wed, Sep 5, 2018 at 11:03 AM, Udo Kohlmeyer wrote: > +1 > > > > On 9/5/18 10:35, Anthony Baker wrote: > >> Before this improvement is re-merged I’d like to see

Re: 2 minute gateway startup time due to GEODE-5591

2018-09-05 Thread Xiaojian Zhou
rate ticket. > > Anthony > > > > On Sep 5, 2018, at 10:43 AM, Xiaojian Zhou wrote: > > > > The fix intend to resolve 2 issues: > > 1) change the exception handling (for a linux version). > > 2) prevent random picking port number to loop forever. In old code, for &g

Re: 2 minute gateway startup time due to GEODE-5591

2018-09-05 Thread Xiaojian Zhou
The fix intend to resolve 2 issues: 1) change the exception handling (for a linux version). 2) prevent random picking port number to loop forever. In old code, for example, if the range only contains one port, random will always pick the same port and it will loop forever. The fix will stop after a

Re: 2 minute gateway startup time due to GEODE-5591

2018-09-05 Thread Xiaojian Zhou
Well, I found it's already reverted. But I think we don't have to. After discussed with Jason, I worked out a new fix. It kept previous 5591's intention of exception handling and improved on assigning the port. The port is now checked if available, so it will also resolve 2 minutes timeout issue

Re: 2 minute gateway startup time due to GEODE-5591

2018-09-04 Thread Xiaojian Zhou
Yes. The current fix is to let each gateway receiver (in hydra tests, there're a lot) to compete port 5500. Only one member will win, all other members will timeout after 2 minutes. Then they keep compete for port 5501. Again, only one member will win. In that case, if there are 5 receivers, it wi

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

2018-08-21 Thread Xiaojian Zhou
+1 The release will be a great one with so many historical bugs fixed. Today I tried to use IJ to build and run with latest build.gradle and recent moved test packages, it worked. So this refactoring is also success. On Tue, Aug 21, 2018 at 3:52 PM, Anthony Baker wrote: > I most definitely agr

Re: 1.6.0 release

2018-04-19 Thread Xiaojian Zhou
I have cherry-picked GEODE-5056 into 9.5 and 1.6.0 On Thu, Apr 19, 2018 at 9:09 AM, Bruce Schuchardt wrote: > Thanks Mike - I've cherry-picked the fix onto the release/1.6.0 branch > > > > On 4/18/18 5:11 PM, Michael Stolz wrote: > >> Yes please. I'm holding the build til this gets in. Please no

Re: [RESULT][VOTE] Apache Geode release - 1.4.0 RC2

2018-02-01 Thread Xiaojian Zhou
+1 On Thu, Feb 1, 2018 at 2:19 PM, Swapnil Bawaskar wrote: > This vote passes with five +1 votes, no 0 or -1 votes. > > Summary: > Dan Smith +1 > Anthony Baker+1 > Sai Boorlagadda +1 > Jinmei Liao +1 > Dick Cavendar+1 > > vote thread: http://markmail

Re: [DISCUSS] Benchmarks module package structure

2018-01-07 Thread Xiaojian Zhou
The package might be always a problem. Even you put the cq benchmark code under geode-cq to near its source code, it might still have to access code under other package, such as geode-core. So I think put benchmark test code under benchmark package is ok. Your option 2) is good. Regards Gester O

Re: PRs should always include tests

2017-12-29 Thread Xiaojian Zhou
How about the code change is already covered by existing tests? Not to reduce test coverage seems a more reasonable standard. On Fri, Dec 29, 2017 at 2:07 PM, Udo Kohlmeyer wrote: > +1 > > > > On 12/29/17 12:05, Kirk Lund wrote: > >> I think we all need to be very consistent in requiring tests

Re: [DISCUSS] Addition of isValid API to Index interface

2017-09-11 Thread Xiaojian Zhou
There's no way to rollback an put/putAll, unless in TX. On Sun, Sep 10, 2017 at 4:21 PM, Jason Huynh wrote: > 1.) Does anyone know of a way to do a rollback where the put is already > reflected in the region? If that is the desired behavior, then perhaps we > will have to live with the current

Review Request 62180: refactor away GemfireCacheImpl.getInstance from lucene function

2017-09-07 Thread xiaojian zhou
/ Testing --- Thanks, xiaojian zhou

Re: Missing Gitbox activation email

2017-09-06 Thread Xiaojian Zhou
I did not get any email. But it seems all set for me. ​ On Wed, Sep 6, 2017 at 4:33 PM, Nabarun Nag wrote: > *I think the email takes some time to arrive."An organisational invite will > be sent to you via email shortly thereafter (within 30 minutes)."* > > On Wed, Sep 6, 2017 at 4:21 PM Dan Sm

Re: Geode PR pile up

2017-07-21 Thread Xiaojian Zhou
I'm merging PR 648 now On Fri, Jul 21, 2017 at 3:32 PM, Jacob Barrett wrote: > All, > > I followed up on the issue regarding abandoned PRs. The only way to close > them if the user has walked away is to do an empty commit. Thanks to Mark > for finding this ticket with explanation > https://issue

Review Request 59926: waitUntilFlush should check if its brq's tempQueue is not empty

2017-06-08 Thread xiaojian zhou
c/test/java/org/apache/geode/cache/lucene/internal/distributed/WaitUntilFlushedFunctionJUnitTest.java f92a296f7 Diff: https://reviews.apache.org/r/59926/diff/1/ Testing --- Thanks, xiaojian zhou

[jira] [Resolved] (GEODE-1775) CI failure: ParallelWANPropagationClientServerDUnitTest.testParallelPropagationWithClientServer

2017-05-11 Thread xiaojian zhou (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiaojian zhou resolved GEODE-1775. -- Resolution: Fixed Fix Version/s: 1.2.0 > CI fail

Review Request 59181: write a dunit test to prove soundex analyzer is easy to apply

2017-05-11 Thread xiaojian zhou
/LuceneQueriesIntegrationTest.java 9db0a5e3a gradle/dependency-versions.properties a9e3fdf46 Diff: https://reviews.apache.org/r/59181/diff/1/ Testing --- Thanks, xiaojian zhou

Re: Review Request 59040: when advisor cannot found target nodes for bucket id, should double check if the member is offline

2017-05-08 Thread Xiaojian Zhou
What happens in the persistent case? Does it throw a > PartitionOfflineException? > > > - Barry Oglesby > > > On May 7, 2017, 5:47 p.m., xiaojian zhou wrote: > > > > --- > > This is

[jira] [Updated] (GEODE-2824) FunctionException: No target node found when executing hasNext on Lucene result

2017-05-08 Thread xiaojian zhou (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiaojian zhou updated GEODE-2824: - Fix Version/s: 1.2.0 > FunctionException: No target node found when executing hasNext on Luc

[jira] [Resolved] (GEODE-2824) FunctionException: No target node found when executing hasNext on Lucene result

2017-05-08 Thread xiaojian zhou (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiaojian zhou resolved GEODE-2824. -- Resolution: Fixed > FunctionException: No target node found when executing hasNext on Luc

Review Request 59040: when advisor cannot found target nodes for bucket id, should double check if the member is offline

2017-05-07 Thread xiaojian zhou
rnal/cache/execute/FunctionExecutionNodePruner.java 18700a75d Diff: https://reviews.apache.org/r/59040/diff/1/ Testing --- Thanks, xiaojian zhou

[jira] [Resolved] (GEODE-1734) Lucene search for a single entry is returning multiple results

2017-05-04 Thread xiaojian zhou (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-1734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiaojian zhou resolved GEODE-1734. -- Resolution: Fixed Fixed in GEODE-2241 revision 0182a1bb744d25fe490d142dfed7d9a6f20b2713

[jira] [Updated] (GEODE-2848) While destroying a LuceneIndex, the AsyncEventQueue region is destroyed in remote members before stopping the AsyncEventQueue

2017-05-03 Thread xiaojian zhou (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiaojian zhou updated GEODE-2848: - Fix Version/s: 1.2.0 > While destroying a LuceneIndex, the AsyncEventQueue region is destroyed

[jira] [Resolved] (GEODE-2848) While destroying a LuceneIndex, the AsyncEventQueue region is destroyed in remote members before stopping the AsyncEventQueue

2017-05-03 Thread xiaojian zhou (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiaojian zhou resolved GEODE-2848. -- Resolution: Fixed fix in revision d4ece31fa23bbe74c8be0a82ff4b9d143bad79b3 > While destroy

[jira] [Assigned] (GEODE-2824) FunctionException: No target node found when executing hasNext on Lucene result

2017-05-02 Thread xiaojian zhou (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiaojian zhou reassigned GEODE-2824: Assignee: xiaojian zhou > FunctionException: No target node found when executing hasN

Re: Review Request 58853: GEODE-2847: Get correct version tags for retried bulk operations

2017-05-01 Thread xiaojian zhou
va Line 561 (original), 560 (patched) <https://reviews.apache.org/r/58853/#comment246545> you don't need to remove here since you have "finally" - xiaojian zhou On May 2, 2017, 1 a.m., Eric Shu wrote: > > ---

[jira] [Commented] (GEODE-2848) While destroying a LuceneIndex, the AsyncEventQueue region is destroyed in remote members before stopping the AsyncEventQueue

2017-05-01 Thread xiaojian zhou (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991583#comment-15991583 ] xiaojian zhou commented on GEODE-2848: -- I think it does not worth to intro

[jira] [Reopened] (GEODE-1988) CI failure: RegisterInterestKeysPRDUnitTest fails intermittently

2017-05-01 Thread xiaojian zhou (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiaojian zhou reopened GEODE-1988: -- It is reproduced in CI FlakeyTest #569 and #564

Re: Review Request 58853: GEODE-2847: Get correct version tags for retried bulk operations

2017-04-28 Thread xiaojian zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58853/#review173386 --- Ship it! Ship It! - xiaojian zhou On April 28, 2017, 8:17

[jira] [Resolved] (GEODE-2806) when batch is dispatched, if the bucket is not primary, we should still destroy the event from queue

2017-04-21 Thread xiaojian zhou (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiaojian zhou resolved GEODE-2806. -- Resolution: Fixed > when batch is dispatched, if the bucket is not primary, we should st

Re: Review Request 58550: AEQ regions being created before the user regions

2017-04-20 Thread xiaojian zhou
che.org/r/58550/#comment245679> This can be omitted. - xiaojian zhou On April 20, 2017, 2:03 a.m., nabarun nag wrote: > > --- > This is an automatically generated e

Review Request 58594: even lost primary, dispatched batch should still be removed

2017-04-20 Thread xiaojian zhou
--- Thanks, xiaojian zhou

[jira] [Assigned] (GEODE-2806) when batch is dispatched, if the bucket is not primary, we should still destroy the event from queue

2017-04-20 Thread xiaojian zhou (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiaojian zhou reassigned GEODE-2806: Assignee: xiaojian zhou > when batch is dispatched, if the bucket is not primary,

[jira] [Created] (GEODE-2806) when batch is dispatched, if the bucket is not primary, we should still destroy the event from queue

2017-04-20 Thread xiaojian zhou (JIRA)
xiaojian zhou created GEODE-2806: Summary: when batch is dispatched, if the bucket is not primary, we should still destroy the event from queue Key: GEODE-2806 URL: https://issues.apache.org/jira/browse/GEODE

[jira] [Resolved] (GEODE-2787) state flush did not wait for notifyGateway

2017-04-14 Thread xiaojian zhou (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiaojian zhou resolved GEODE-2787. -- Resolution: Fixed > state flush did not wait for notifyGate

[jira] [Updated] (GEODE-2787) state flush did not wait for notifyGateway

2017-04-14 Thread xiaojian zhou (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiaojian zhou updated GEODE-2787: - Labels: lucene (was: ) > state flush did not wait for notifyGate

[jira] [Created] (GEODE-2787) state flush did not wait for notifyGateway

2017-04-14 Thread xiaojian zhou (JIRA)
xiaojian zhou created GEODE-2787: Summary: state flush did not wait for notifyGateway Key: GEODE-2787 URL: https://issues.apache.org/jira/browse/GEODE-2787 Project: Geode Issue Type: Bug

[jira] [Assigned] (GEODE-2787) state flush did not wait for notifyGateway

2017-04-14 Thread xiaojian zhou (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiaojian zhou reassigned GEODE-2787: Assignee: xiaojian zhou > state flush did not wait for notifyGate

Re: [VOTE] Apache Geode release - v1.1.1 RC2

2017-03-31 Thread Xiaojian Zhou
+1 built from source and run several dunits (the ones showed in regression #50) On Fri, Mar 31, 2017 at 9:04 AM, Dick Cavender wrote: > +1 > > Built source and ran tests successfully on RH. > > Ran gfsh on binary dist to start and stop locator and system. > > > > On 3/30/2017 4:58 PM, Anthony Ba

[jira] [Commented] (GEODE-1894) SerialGatewaySenderOperationsDUnitTest test hangs

2017-03-29 Thread xiaojian zhou (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-1894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15947572#comment-15947572 ] xiaojian zhou commented on GEODE-1894: -- It was not reproducible but we found

[jira] [Issue Comment Deleted] (GEODE-1894) SerialGatewaySenderOperationsDUnitTest test hangs

2017-03-29 Thread xiaojian zhou (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-1894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiaojian zhou updated GEODE-1894: - Comment: was deleted (was: Re-run the test using the current revision and even Sep 12's rev

Re: Review Request 57740: GEODE-2679: Lucene asynchronous disk writes for aeq can lead to data mismatch after compacting

2017-03-17 Thread xiaojian zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57740/#review169350 --- Ship it! Ship It! - xiaojian zhou On March 17, 2017, 11:41

  1   2   >