Github user scmbuildguy commented on the issue:
https://github.com/apache/geode/pull/733
I am hesitant about this change since it doesn't follow the Gradle workflow
very well.
Would it be possible to include old versions as dependencies? Maybe then we
could leverage G
Github user scmbuildguy commented on the issue:
https://github.com/apache/geode/pull/621
Thanks! It was not clear from the history of the pull request.
--Mark
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user scmbuildguy commented on the issue:
https://github.com/apache/geode/pull/621
This was opened for about 90 minutes before it was merged into develop. Was
there a review done by a committer on this code?
---
If your project is set up for it, you can reply to this email
Github user scmbuildguy commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/69#discussion_r107524018
--- Diff:
docs/geode-native-docs/cpp-caching-api/accessing-entry.html.md.erb ---
@@ -35,11 +35,11 @@ for ( int32_t i=0; i< 100
Github user scmbuildguy commented on a diff in the pull request:
https://github.com/apache/geode-site/pull/1#discussion_r103041344
--- Diff: build.gradle ---
@@ -16,10 +16,50 @@
*/
plugins {
- id "org.nosphere.apache.rat" version "0
Github user scmbuildguy commented on a diff in the pull request:
https://github.com/apache/geode-site/pull/1#discussion_r103036407
--- Diff: README.md ---
@@ -20,3 +20,58 @@ limitations under the License.
[![Build
Status](https://travis-ci.org/apache/geode-site.svg?branch
Github user scmbuildguy commented on a diff in the pull request:
https://github.com/apache/geode-site/pull/1#discussion_r103036769
--- Diff: build.gradle ---
@@ -16,10 +16,50 @@
*/
plugins {
- id "org.nosphere.apache.rat" version "0
Github user scmbuildguy commented on a diff in the pull request:
https://github.com/apache/geode-site/pull/1#discussion_r103038157
--- Diff: README.md ---
@@ -20,3 +20,58 @@ limitations under the License.
[![Build
Status](https://travis-ci.org/apache/geode-site.svg?branch
Github user scmbuildguy commented on a diff in the pull request:
https://github.com/apache/geode/pull/398#discussion_r101351743
--- Diff:
geode-redis/src/test/java/org/apache/geode/redis/AuthJUnitTest.java ---
@@ -0,0 +1,120 @@
+/*
+ * Licensed to the Apache Software
Github user scmbuildguy commented on a diff in the pull request:
https://github.com/apache/geode/pull/398#discussion_r101350393
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/GeodeRedisService.java ---
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software
Github user scmbuildguy commented on the issue:
https://github.com/apache/geode/pull/380
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user scmbuildguy commented on the issue:
https://github.com/apache/geode/pull/342
+1 for this round
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user scmbuildguy commented on the issue:
https://github.com/apache/geode-examples/pull/1
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user scmbuildguy commented on the issue:
https://github.com/apache/geode/pull/322
+1 - I agree with generating these files should be done at build time and
not checked into source.
---
If your project is set up for it, you can reply to this email and have your
reply appear
14 matches
Mail list logo