[GitHub] geode issue #733: Keeping old versions around even during a clean

2017-08-23 Thread scmbuildguy
Github user scmbuildguy commented on the issue: https://github.com/apache/geode/pull/733 I am hesitant about this change since it doesn't follow the Gradle workflow very well. Would it be possible to include old versions as dependencies? Maybe then we could leverage G

[GitHub] geode issue #621: GEODE-3129 - Added error messages to protobuf protocol

2017-07-07 Thread scmbuildguy
Github user scmbuildguy commented on the issue: https://github.com/apache/geode/pull/621 Thanks! It was not clear from the history of the pull request. --Mark --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] geode issue #621: GEODE-3129 - Added error messages to protobuf protocol

2017-07-07 Thread scmbuildguy
Github user scmbuildguy commented on the issue: https://github.com/apache/geode/pull/621 This was opened for about 90 minutes before it was merged into develop. Was there a review done by a committer on this code? --- If your project is set up for it, you can reply to this email

[GitHub] geode-native pull request #69: GEODE-2513 Unbrand C++ API docs

2017-03-22 Thread scmbuildguy
Github user scmbuildguy commented on a diff in the pull request: https://github.com/apache/geode-native/pull/69#discussion_r107524018 --- Diff: docs/geode-native-docs/cpp-caching-api/accessing-entry.html.md.erb --- @@ -35,11 +35,11 @@ for ( int32_t i=0; i< 100

[GitHub] geode-site pull request #1: GEODE-2507 Add gradle tasks for compile and view

2017-02-24 Thread scmbuildguy
Github user scmbuildguy commented on a diff in the pull request: https://github.com/apache/geode-site/pull/1#discussion_r103041344 --- Diff: build.gradle --- @@ -16,10 +16,50 @@ */ plugins { - id "org.nosphere.apache.rat" version "0

[GitHub] geode-site pull request #1: GEODE-2507 Add gradle tasks for compile and view

2017-02-24 Thread scmbuildguy
Github user scmbuildguy commented on a diff in the pull request: https://github.com/apache/geode-site/pull/1#discussion_r103036407 --- Diff: README.md --- @@ -20,3 +20,58 @@ limitations under the License. [![Build Status](https://travis-ci.org/apache/geode-site.svg?branch

[GitHub] geode-site pull request #1: GEODE-2507 Add gradle tasks for compile and view

2017-02-24 Thread scmbuildguy
Github user scmbuildguy commented on a diff in the pull request: https://github.com/apache/geode-site/pull/1#discussion_r103036769 --- Diff: build.gradle --- @@ -16,10 +16,50 @@ */ plugins { - id "org.nosphere.apache.rat" version "0

[GitHub] geode-site pull request #1: GEODE-2507 Add gradle tasks for compile and view

2017-02-24 Thread scmbuildguy
Github user scmbuildguy commented on a diff in the pull request: https://github.com/apache/geode-site/pull/1#discussion_r103038157 --- Diff: README.md --- @@ -20,3 +20,58 @@ limitations under the License. [![Build Status](https://travis-ci.org/apache/geode-site.svg?branch

[GitHub] geode pull request #398: Split the redis adapter into its own package

2017-02-15 Thread scmbuildguy
Github user scmbuildguy commented on a diff in the pull request: https://github.com/apache/geode/pull/398#discussion_r101351743 --- Diff: geode-redis/src/test/java/org/apache/geode/redis/AuthJUnitTest.java --- @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software

[GitHub] geode pull request #398: Split the redis adapter into its own package

2017-02-15 Thread scmbuildguy
Github user scmbuildguy commented on a diff in the pull request: https://github.com/apache/geode/pull/398#discussion_r101350393 --- Diff: geode-core/src/main/java/org/apache/geode/redis/GeodeRedisService.java --- @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software

[GitHub] geode issue #380: GEODE-2409: Beautify readme

2017-02-01 Thread scmbuildguy
Github user scmbuildguy commented on the issue: https://github.com/apache/geode/pull/380 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] geode issue #342: GEODE-2309: Replace Pivotal Copyright and add Apache Licen...

2017-01-20 Thread scmbuildguy
Github user scmbuildguy commented on the issue: https://github.com/apache/geode/pull/342 +1 for this round --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] geode-examples issue #1: GEODE-2260: Revise geode-examples to be in their ow...

2017-01-06 Thread scmbuildguy
Github user scmbuildguy commented on the issue: https://github.com/apache/geode-examples/pull/1 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] geode issue #322: [GEODE-165] Fix for Add build support for generating antlr...

2016-12-21 Thread scmbuildguy
Github user scmbuildguy commented on the issue: https://github.com/apache/geode/pull/322 +1 - I agree with generating these files should be done at build time and not checked into source. --- If your project is set up for it, you can reply to this email and have your reply appear