Github user jujoramos commented on the issue:
https://github.com/apache/geode/pull/664
@jinmeiliao: thanks for reviewing this :-).
One more quick question and I'll leave you alone: do I need to change the
status of [GEODE-3292](https://issues.apache.org/jira/browse/GEODE-329
Github user jujoramos commented on a diff in the pull request:
https://github.com/apache/geode/pull/664#discussion_r131378087
--- Diff:
geode-assembly/src/test/java/org/apache/geode/tools/pulse/AbstractPulseConnectivityTest.java
---
@@ -15,26 +15,31 @@
package
Github user jujoramos commented on a diff in the pull request:
https://github.com/apache/geode/pull/664#discussion_r131367740
--- Diff:
geode-pulse/src/test/java/org/apache/geode/tools/pulse/internal/PulseAppListenerTest.java
---
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the
Github user jujoramos commented on a diff in the pull request:
https://github.com/apache/geode/pull/664#discussion_r131071385
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/ManagementAgent.java
---
@@ -270,6 +271,7 @@ private void startHttpService(boolean
Github user jujoramos commented on a diff in the pull request:
https://github.com/apache/geode/pull/664#discussion_r131071365
--- Diff:
geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseConnectivityTest.java
---
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the
Github user jujoramos commented on a diff in the pull request:
https://github.com/apache/geode/pull/664#discussion_r131071353
--- Diff:
geode-assembly/src/test/java/org/apache/geode/tools/pulse/PulseConnectivityTest.java
---
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the
Github user jujoramos commented on the issue:
https://github.com/apache/geode/pull/664
Hello @jaredjstewart,
Just pushed the requested changes.
- Renamed `PulseVerificationTest` to `PulseConnectivityTest`.
- Removed `loginWithIncorrectPassword` test method, it is
Github user jujoramos commented on the issue:
https://github.com/apache/geode/pull/664
Hey @jaredjstewart,
Thanks for looking at this.
I'll write the tests, no worries at all.
Cheers.
---
If your project is set up for it, you can reply to this email and have
GitHub user jujoramos opened a pull request:
https://github.com/apache/geode/pull/664
Fix for GEODE-3292
Embedded PULSE Connection Failure When jmx-manager-bind-address != localhost
- ManagementAgent sets the 'pulse.host' system property whenever a
'j
