[GitHub] geode pull request #739: GEODE-3385: Change GetAllRequest to return list of ...

2017-08-29 Thread hiteshk25
Github user hiteshk25 commented on a diff in the pull request: https://github.com/apache/geode/pull/739#discussion_r135883931 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandler.java --- @@ -50,26 +53,52

[GitHub] geode pull request #746: GEODE-3529 move new client/server security classes ...

2017-08-29 Thread hiteshk25
Github user hiteshk25 commented on a diff in the pull request: https://github.com/apache/geode/pull/746#discussion_r135871358 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java --- @@ -57,15 +57,14 @@ private synchronized

[GitHub] geode pull request #746: GEODE-3529 move new client/server security classes ...

2017-08-29 Thread hiteshk25
Github user hiteshk25 commented on a diff in the pull request: https://github.com/apache/geode/pull/746#discussion_r135871243 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java --- @@ -57,15 +57,14 @@ private synchronized

[GitHub] geode pull request #746: GEODE-3529 move new client/server security classes ...

2017-08-29 Thread hiteshk25
Github user hiteshk25 commented on a diff in the pull request: https://github.com/apache/geode/pull/746#discussion_r135870888 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java --- @@ -41,8 +41,8 @@ private synchronized

[GitHub] geode pull request #702: GEODE-3416: Reduce synchronization blockages in Soc...

2017-08-16 Thread hiteshk25
Github user hiteshk25 commented on a diff in the pull request: https://github.com/apache/geode/pull/702#discussion_r133506959 --- Diff: geode-core/src/main/java/org/apache/geode/internal/net/SocketCloser.java --- @@ -96,46 +99,55 @@ public int getMaxThreads() { return

[GitHub] geode pull request #702: GEODE-3416: Reduce synchronization blockages in Soc...

2017-08-15 Thread hiteshk25
Github user hiteshk25 commented on a diff in the pull request: https://github.com/apache/geode/pull/702#discussion_r133251379 --- Diff: geode-core/src/main/java/org/apache/geode/internal/net/SocketCloser.java --- @@ -96,46 +99,55 @@ public int getMaxThreads() { return

[GitHub] geode pull request #702: GEODE-3416: Reduce synchronization blockages in Soc...

2017-08-15 Thread hiteshk25
Github user hiteshk25 commented on a diff in the pull request: https://github.com/apache/geode/pull/702#discussion_r133249141 --- Diff: geode-core/src/main/java/org/apache/geode/internal/tcp/ConnectionTable.java --- @@ -929,10 +929,6 @@ protected void removeEndpoint

[GitHub] geode pull request #404: Geode 2469

2017-03-01 Thread hiteshk25
Github user hiteshk25 commented on a diff in the pull request: https://github.com/apache/geode/pull/404#discussion_r103499836 --- Diff: geode-core/src/main/java/org/apache/geode/redis/internal/RegionProvider.java --- @@ -259,6 +307,16 @@ public void

[GitHub] geode pull request #404: Geode 2469

2017-02-28 Thread hiteshk25
Github user hiteshk25 commented on a diff in the pull request: https://github.com/apache/geode/pull/404#discussion_r103497182 --- Diff: geode-core/src/main/java/org/apache/geode/redis/internal/RegionProvider.java --- @@ -187,8 +217,26 @@ public boolean removeKey(ByteArrayWrapper