[GitHub] geode-native pull request #104: GEODE-3143 : close socket before deteting

2017-07-02 Thread fdaniel7
Github user fdaniel7 closed the pull request at: https://github.com/apache/geode-native/pull/104 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] geode-native issue #104: GEODE-3143 : close socket before deteting

2017-06-28 Thread fdaniel7
Github user fdaniel7 commented on the issue: https://github.com/apache/geode-native/pull/104 When connect() is invoked from one of TcpConn::TcpConn the TcpConn object is not created since the exception is thrown from the constructor, so ~TcpConn will not be invoked. --- If your

[GitHub] geode-native issue #104: Develop

2017-06-28 Thread fdaniel7
Github user fdaniel7 commented on the issue: https://github.com/apache/geode-native/pull/104 There's no ticket for this as far as I know. I'm fixing this as part of reviewing geode client code --- If your project is set up for it, you can reply to this email and have

[GitHub] geode-native issue #104: Develop

2017-06-28 Thread fdaniel7
Github user fdaniel7 commented on the issue: https://github.com/apache/geode-native/pull/104 Hi I'm still new with github, it is indeed a small change. On next contributions I'll pay more attention. --- If your project is set up for it, you can reply to this email and

[GitHub] geode-native pull request #104: Develop

2017-06-28 Thread fdaniel7
GitHub user fdaniel7 opened a pull request: https://github.com/apache/geode-native/pull/104 Develop Closing socket before deleting it. You can merge this pull request into a Git repository by running: $ git pull https://github.com/fdaniel7/geode-native develop Alternatively