Github user echobravopapa commented on the issue:
https://github.com/apache/geode-native/pull/113
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user echobravopapa closed the pull request at:
https://github.com/apache/geode-native/pull/107
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user echobravopapa closed the pull request at:
https://github.com/apache/geode-native/pull/98
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user echobravopapa commented on the issue:
https://github.com/apache/geode-native/pull/107
@dgkimura @pivotal-jbarrett I think this is all ready for final inspection
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/107#discussion_r127315288
--- Diff: src/cppcache/src/StructSetImpl.cpp ---
@@ -78,13 +78,12 @@ int32_t StructSetImpl::getFieldIndex(const char*
fieldname
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/107#discussion_r127285583
--- Diff: src/cppcache/src/StructSetImpl.cpp ---
@@ -66,8 +66,8 @@ SelectResultsIterator StructSetImpl::getIterator() {
return
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/107#discussion_r127285563
--- Diff: src/cppcache/src/StructSetImpl.cpp ---
@@ -78,13 +78,12 @@ int32_t StructSetImpl::getFieldIndex(const char*
fieldname
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/107#discussion_r127285623
--- Diff: src/cppcache/src/StructSetImpl.cpp ---
@@ -66,8 +66,8 @@ SelectResultsIterator StructSetImpl::getIterator() {
return
Github user echobravopapa commented on the issue:
https://github.com/apache/geode-native/pull/107
@dgkimura @pivotal-jbarrett added unit tests and throwing an exception for
out of range now
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user echobravopapa commented on the issue:
https://github.com/apache/geode-native/pull/107
@dgkimura @pivotal-jbarrett I squashed the latest so you won't get
notified, which is a bummer, but please have a look when you have a minute.
---
If your project is set up for it
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/107#discussion_r126030201
--- Diff: src/cppcache/integration-test/testThinClientRemoteQuerySS.cpp ---
@@ -56,59 +57,63 @@ const wchar_t* checkNullString(const wchar_t* str
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/107#discussion_r126029862
--- Diff: src/cppcache/include/geode/Struct.hpp ---
@@ -138,7 +138,7 @@ class CPPCACHE_EXPORT Struct : public Serializable {
* Returns
GitHub user echobravopapa opened a pull request:
https://github.com/apache/geode-native/pull/107
GEODE-3019: Refactor Struct class
- Using std::string now
- this also addresses GEODE-3020, the map now used standard types
You can merge this pull request into a Git
Github user echobravopapa commented on the issue:
https://github.com/apache/geode-native/pull/106
@pivotal-jbarrett fair enough on the branching point, I think the rest is
still a valid ask
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user echobravopapa commented on the issue:
https://github.com/apache/geode-native/pull/106
@gregt5259 a couple quick items of feedback that need to be addressed
before this is reviewed:
- please squash your commits, this cleans up the diffs for everyone to
better
Github user echobravopapa commented on the issue:
https://github.com/apache/geode-native/pull/104
@fdaniel7 please close this PR, thx
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user echobravopapa commented on the issue:
https://github.com/apache/geode-native/pull/104
@fdaniel7 What is the GEODE ticket you are working on?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user echobravopapa opened a pull request:
https://github.com/apache/geode-native/pull/98
Test commit for Vince & Scott
DO NOT MERGE THIS!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/echobravopapa/geode-native fea
Github user echobravopapa commented on the issue:
https://github.com/apache/geode-native/pull/90
@ameybarve15 it is simpler to start with a fresh feature branch and follow
what @pivotal-jbarrett suggests
---
If your project is set up for it, you can reply to this email and have your
Github user echobravopapa commented on the issue:
https://github.com/apache/geode-native/pull/90
@ameybarve15 @PivotalSarge will have a look at this soon.
May we stay on the feature branch until the PR is approved, which will
alleviate the "merge" commit...
-
Github user echobravopapa commented on the issue:
https://github.com/apache/geode-native/pull/93
I thought so too...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user echobravopapa commented on the issue:
https://github.com/apache/geode-native/pull/90
@ameybarve15 would you please squash your commits, TIA
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/82#discussion_r109942702
--- Diff:
src/cppcache/integration-test/testThinClientPoolExecuteFunctionThrowsException.cpp
---
@@ -303,6 +303,7 @@ DUNIT_TASK_DEFINITION
Github user echobravopapa commented on the issue:
https://github.com/apache/geode-native/pull/76
@mmartell merged, please close
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user echobravopapa commented on the issue:
https://github.com/apache/geode-native/pull/83
@dgkimura merged, please close
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user echobravopapa commented on the issue:
https://github.com/apache/geode-native/pull/74
@PivotalSarge need to clean up this PR, should not have all of the docs
commits included, TIA
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/83#discussion_r109743478
--- Diff: src/cppcache/src/ExecutionImpl.cpp ---
@@ -100,33 +94,31 @@ ResultCollectorPtr ExecutionImpl::execute(const char*
fn, uint32_t timeout
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/83#discussion_r109743229
--- Diff: src/cppcache/src/ExecutionImpl.cpp ---
@@ -100,33 +94,31 @@ ResultCollectorPtr ExecutionImpl::execute(const char*
fn, uint32_t timeout
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/82#discussion_r109462974
--- Diff:
src/cppcache/integration-test/testThinClientPoolExecuteFunctionThrowsException.cpp
---
@@ -0,0 +1,362 @@
+/*
+ * Licensed to
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/74#discussion_r107995174
--- Diff: src/cppcache/src/ThinClientRegion.hpp ---
@@ -416,14 +416,21 @@ class ChunkedFunctionExecutionResponse : public
TcrChunkedResult
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/74#discussion_r107994818
--- Diff: src/cppcache/src/ThinClientRegion.hpp ---
@@ -416,14 +416,21 @@ class ChunkedFunctionExecutionResponse : public
TcrChunkedResult
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/74#discussion_r107992569
--- Diff: src/cppcache/src/ThinClientRegion.hpp ---
@@ -416,14 +416,21 @@ class ChunkedFunctionExecutionResponse : public
TcrChunkedResult
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/73#discussion_r107950987
--- Diff:
docs/geode-native-docs/introduction/developing-windows.html.md.erb ---
@@ -21,18 +21,18 @@ limitations under the License
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/73#discussion_r107950403
--- Diff:
docs/geode-native-docs/introduction/developing-solaris.html.md.erb ---
@@ -19,25 +19,25 @@ See the License for the specific language
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/73#discussion_r107950013
--- Diff: docs/geode-native-docs/introduction/developing-linux.html.md.erb
---
@@ -19,48 +19,48 @@ See the License for the specific language
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/73#discussion_r107950857
--- Diff:
docs/geode-native-docs/introduction/developing-windows.html.md.erb ---
@@ -21,18 +21,18 @@ limitations under the License
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/71#discussion_r107770677
--- Diff: src/cppcache/integration-test/testThinClientSSLAuthFail.cpp ---
@@ -15,8 +15,180 @@
* limitations under the License
GitHub user echobravopapa opened a pull request:
https://github.com/apache/geode-native/pull/72
GEODE-2712: Fixed cpp quickstarts building on Windows.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/echobravopapa/geode-native
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/70#discussion_r107542483
--- Diff: src/cppcache/integration-test/CacheHelper.cpp ---
@@ -1376,6 +1376,41 @@ void
CacheHelper::createDuplicateXMLFile(std::string
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/70#discussion_r107535535
--- Diff: src/cppcache/integration-test/CacheHelper.cpp ---
@@ -1376,6 +1376,41 @@ void
CacheHelper::createDuplicateXMLFile(std::string
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/62#discussion_r106952554
--- Diff:
docs/geode-native-docs/connection-pools/native-client-pool-api.html.md.erb ---
@@ -19,14 +19,14 @@ See the License for the specific
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/63#discussion_r106933661
--- Diff:
src/clicache/integration-test/ThinClientFunctionExecutionTestsN.cs ---
@@ -959,7 +959,7 @@ public void ExecuteFETimeOut
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/63#discussion_r106929938
--- Diff: src/clicache/src/CacheFactory.cpp ---
@@ -84,6 +85,12 @@ namespace Apache
//TODO::split
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/63#discussion_r106924902
--- Diff:
src/cppcache/integration-test/testThinClientPoolExecuteFunction.cpp ---
@@ -1158,9 +1160,10 @@ DUNIT_TASK_DEFINITION(CLIENT1
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/63#discussion_r106924253
--- Diff:
src/cppcache/integration-test/testThinClientExecuteFunctionPrSHOP.cpp ---
@@ -563,7 +563,7 @@ DUNIT_TASK_DEFINITION(CLIENT1
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/63#discussion_r106926886
--- Diff:
src/clicache/integration-test/ThinClientFunctionExecutionTestsN.cs ---
@@ -959,7 +959,7 @@ public void ExecuteFETimeOut
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/63#discussion_r106926117
--- Diff:
src/cppcache/integration-test/testThinClientPoolExecuteFunction.cpp ---
@@ -1506,48 +1353,10 @@ void runFunctionExecution(bool
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/63#discussion_r106923938
--- Diff: src/cppcache/integration-test/CMakeLists.txt ---
@@ -169,8 +169,6 @@ set_property(TEST testThinClientPartitionResolver
PROPERTY LABELS
GitHub user echobravopapa opened a pull request:
https://github.com/apache/geode-native/pull/61
GEODE-2687: test for ssl auth failure:
- Added testThinClientSSLAuthFail to QUICK list.
- removed un-needed test code.
- catching expected exception
- Add test for untrusted
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/60#discussion_r106726114
--- Diff: BUILDING.md ---
@@ -77,7 +77,7 @@ Due to limitations in CMake, the documentation must be
built as a separate step
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/59#discussion_r106471945
--- Diff:
docs/geode-native-docs/function-execution/solutions-use-cases.html.md.erb ---
@@ -19,7 +19,7 @@ See the License for the specific
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/57#discussion_r106279511
--- Diff:
docs/geode-native-book/master_middleman/source/subnavs/geode-nc-nav.erb ---
@@ -883,7 +883,7 @@ limitations under the License
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/50#discussion_r105265184
--- Diff: src/quickstart/cpp/PdxSerializer.cpp ---
@@ -165,15 +165,15 @@ int main(int argc, char** argv) {
LOGINFO("Registered P
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/49#discussion_r105257135
--- Diff:
docs/geode-native-docs/preserving-data/configuring-durable-nc.html.md.erb ---
@@ -19,19 +19,19 @@ See the License for the specific
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/49#discussion_r105222610
--- Diff:
docs/geode-native-docs/preserving-data/configuring-durable-nc.html.md.erb ---
@@ -19,19 +19,19 @@ See the License for the specific
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/49#discussion_r105222443
--- Diff:
docs/geode-native-docs/preserving-data/configuring-durable-nc.html.md.erb ---
@@ -19,19 +19,19 @@ See the License for the specific
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/48#discussion_r105204008
--- Diff: src/cppcache/include/geode/DataOutput.hpp ---
@@ -378,9 +378,8 @@ class CPPCACHE_EXPORT DataOutput {
*/
inline void
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/48#discussion_r104759431
--- Diff: src/cppcache/src/TcrMessage.hpp ---
@@ -555,7 +555,7 @@ class CPPCACHE_EXPORT TcrMessage {
const
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/48#discussion_r104766406
--- Diff: src/cppcache/include/geode/DataOutput.hpp ---
@@ -378,9 +378,8 @@ class CPPCACHE_EXPORT DataOutput {
*/
inline void
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/48#discussion_r104766552
--- Diff: src/cppcache/test/DataOutputTest.cpp ---
@@ -305,15 +305,9 @@ TEST_F(DataOutputTest, TestCursorAdvance
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/48#discussion_r104759602
--- Diff: src/cppcache/src/TcrMessage.cpp ---
@@ -756,8 +756,8 @@ void TcrMessage::writeRegionPart(const std::string&
region
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/48#discussion_r104768254
--- Diff: src/cppcache/test/TcrMessage_unittest.cpp ---
@@ -559,3 +560,66 @@ TEST_F(TcrMessageTest,
testConstructorEXECUTE_FUNCTION
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/42#discussion_r103713640
--- Diff: src/quickstart/cpp/CMakeLists.txt ---
@@ -26,16 +26,6 @@ elseif(UNIX)
set(DYNAMIC_LIBRARY_PATH LD_LIBRARY_PATH
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/42#discussion_r103568564
--- Diff: src/quickstart/runcpp.sh.in ---
@@ -69,7 +69,6 @@ else
echo 22.PdxRemoteQuery
echo 23.PdxSerializer
echo 24
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/42#discussion_r103568625
--- Diff: src/quickstart/runcpp.sh.in ---
@@ -150,9 +149,6 @@ else
"24")
exname='PdxInstance'
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/42#discussion_r103569428
--- Diff: src/quickstart/cpp/CMakeLists.txt ---
@@ -26,16 +26,6 @@ elseif(UNIX)
set(DYNAMIC_LIBRARY_PATH LD_LIBRARY_PATH
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103490344
--- Diff: src/cppcache/integration-test/testSpinLock.cpp ---
@@ -20,48 +20,44 @@
#include "fw_dunit.hpp"
#include
Github user echobravopapa commented on the issue:
https://github.com/apache/geode-native/pull/39
I quoted the target, suspecting find would not like it otherwise...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user echobravopapa commented on the issue:
https://github.com/apache/geode-native/pull/39
@PivotalSarge .ratignore is in the base dir of geode-native
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user echobravopapa commented on the issue:
https://github.com/apache/geode/pull/245
@doribd yes, @fdaniel7 should close the PR on
apache/geode/native-client-software-grant
and then switch to https://github.com/apache/geode-native and re-open the
PR there as appropriate
Github user echobravopapa commented on the issue:
https://github.com/apache/geode-native/pull/32
@dgkimura STABLE tests passing?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user echobravopapa commented on the issue:
https://github.com/apache/geode-native/pull/27
@dgkimura yes, you want to handle all that locally... it was just your turn
to fall for Github's siren song
---
If your project is set up for it, you can reply to this email and
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102831481
--- Diff: src/cppcache/src/ThinClientRegion.hpp ---
@@ -149,7 +149,7 @@ class CPPCACHE_EXPORT ThinClientRegion : public
LocalRegion
Github user echobravopapa commented on the issue:
https://github.com/apache/geode-native/pull/30
@pivotal-jbarrett good question, @mmartell where do the files go to now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/28#discussion_r102809166
--- Diff:
src/cppcache/integration-test/testThinClientFixedPartitionResolver.cpp ---
@@ -236,8 +236,8 @@ DUNIT_TASK_DEFINITION(CLIENT1
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102747970
--- Diff: src/cppcache/src/ThinClientRegion.hpp ---
@@ -149,7 +149,7 @@ class CPPCACHE_EXPORT ThinClientRegion : public
LocalRegion
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102743038
--- Diff: src/cppcache/src/PdxHelper.cpp ---
@@ -183,9 +183,9 @@ void PdxHelper::serializePdx(DataOutput& output,
n
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102743535
--- Diff: src/cppcache/src/PdxType.hpp ---
@@ -89,7 +89,7 @@ class PdxType : public Serializable,
int32_t* m_localToRemoteFieldMap
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102756763
--- Diff: src/cppcache/src/statistics/StatArchiveWriter.cpp ---
@@ -228,10 +228,10 @@ void ResourceInst::writeStatValue(StatisticDescriptor
*sd
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102742761
--- Diff: src/cppcache/src/Log.cpp ---
@@ -732,7 +732,7 @@ void Log::put(LogLevel level, const char* msg) {
// struct dirent
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/27#discussion_r102757059
--- Diff: src/cppcache/src/statistics/StatArchiveWriter.cpp ---
@@ -434,17 +434,17 @@ void StatArchiveWriter::openFile(std::string
filename
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/24#discussion_r102539038
--- Diff: src/cppcache/src/CppCacheLibrary.cpp ---
@@ -127,15 +127,18 @@ std::string CppCacheLibrary::getProductLibDir() {
for (int i = 0
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/24#discussion_r102538789
--- Diff: src/cppcache/src/CMakeLists.txt ---
@@ -125,7 +125,7 @@ target_include_directories(apache-geode
$
)
add_dependencies
GitHub user echobravopapa opened a pull request:
https://github.com/apache/geode-native/pull/24
GEODE-2508: Initial work on new approach to generic lib naming.
Keeping the changes to CppCacheLibrary.cpp - did not, yet, find a CMake way
to do it more seamlessly.
You can merge this
Github user echobravopapa commented on the issue:
https://github.com/apache/geode-native/pull/19
Closing to take different approach.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user echobravopapa closed the pull request at:
https://github.com/apache/geode-native/pull/19
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user echobravopapa opened a pull request:
https://github.com/apache/geode-native/pull/19
GEODE-2508: Inital work on making lib names generic.
Just a sneak peak, I think I may have a couple tweaks/additions next week.
You can merge this pull request into a Git repository by
Github user echobravopapa commented on the issue:
https://github.com/apache/geode-native/pull/18
Wise choice, this can revisited in the future when the community has more
time and inclination to make the jump to a toolchain with complete or more
complete C++11 support.
---
If your
Github user echobravopapa closed the pull request at:
https://github.com/apache/geode-native/pull/14
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user echobravopapa opened a pull request:
https://github.com/apache/geode-native/pull/14
GEODE-348: fix cast to be in compliance with standards.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/echobravopapa/geode-native
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/11#discussion_r101287739
--- Diff: src/cryptoimpl/SSLImpl.cpp ---
@@ -52,25 +52,23 @@ SSLImpl::SSLImpl(ACE_SOCKET sock, const char
*pubkeyfile,
if (SSLImpl
Github user echobravopapa commented on the issue:
https://github.com/apache/geode/pull/391
@metatype in fact, we do have separate stories for the rest.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user echobravopapa commented on the issue:
https://github.com/apache/geode/pull/391
We should have separate stories/jiras for those items.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode/pull/391#discussion_r100191415
--- Diff: src/clicache/integration-test/CacheHelperN.cs ---
@@ -2389,7 +2389,7 @@ public static void KillJavaProcesses()
string
Github user echobravopapa commented on the issue:
https://github.com/apache/geode/pull/391
Conflicts are removed. ready for Merge!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user echobravopapa commented on the issue:
https://github.com/apache/geode/pull/387
+1 ready for merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode/pull/394#discussion_r99889754
--- Diff: .travis.yml ---
@@ -0,0 +1,43 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license
Github user echobravopapa commented on a diff in the pull request:
https://github.com/apache/geode/pull/394#discussion_r99858609
--- Diff: .travis.yml ---
@@ -0,0 +1,43 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license
Github user echobravopapa closed the pull request at:
https://github.com/apache/geode/pull/386
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user echobravopapa opened a pull request:
https://github.com/apache/geode/pull/386
Feature/geode 2421
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/echobravopapa/geode feature/GEODE-2421
Alternatively you can review
1 - 100 of 122 matches
Mail list logo
